Add 4 digit uid to dump file names #4509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vlstill
reviewed
Mar 7, 2024
ChrisDodd
force-pushed
the
cdodd-dumpname
branch
from
3168c50
to
e50e3a3
Compare
vlstill
approved these changes
Mar 8, 2024
ChrisDodd
force-pushed
the
cdodd-dumpname
branch
from
e50e3a3
to
878464a
Compare
ChrisDodd
force-pushed
the
cdodd-dumpname
branch
from
878464a
to
3ff1187
Compare
fruffy
added
the
core
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed an issue with dumping passes that get called more than once, generally in a
PassRepeated-- the filename generated is the same, so the dumps overwrite and you end up with only the last iteration of the pass. This change adds a unique index number so you get mulitple files, and as a bonus, the files will be sorted in order inls