Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move out of place comment in gc.cpp #4494

Merged
merged 2 commits into from
Mar 2, 2024
Merged

Conversation

kfcripps
Copy link
Contributor

@kfcripps kfcripps commented Mar 1, 2024

Based on the git history (27ab2c7#diff-3f329039fda7acd3a6dfa342bcf5181e5aeca86642c0c96bb8ccf1086a887028R13), it seems like it belongs somewhere around #ifdef HAVE_LIBGC, which has already been moved

@kfcripps kfcripps requested a review from asl March 1, 2024 21:28
@kfcripps kfcripps enabled auto-merge March 1, 2024 21:29
@asl
Copy link
Contributor

asl commented Mar 1, 2024

Yes, it was moved to proper place :)

lib/gc.cpp Outdated Show resolved Hide resolved
@kfcripps kfcripps added this pull request to the merge queue Mar 1, 2024
@kfcripps kfcripps removed this pull request from the merge queue due to a manual request Mar 1, 2024
Co-authored-by: Fabian Ruffy <5960321+fruffy@users.noreply.github.com>
@kfcripps kfcripps enabled auto-merge March 1, 2024 22:26
@kfcripps kfcripps added this pull request to the merge queue Mar 1, 2024
Merged via the queue into p4lang:main with commit 7ed159a Mar 2, 2024
17 checks passed
@kfcripps kfcripps deleted the move-comment branch March 2, 2024 00:17
@fruffy fruffy added the core Topics concerning the core segments of the compiler (frontend, midend, parser) label Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Topics concerning the core segments of the compiler (frontend, midend, parser)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants