Do not toggle BOOST_NO_ARGUMENT_DEPENDENT_LOOKUP in CMakelists.txt

[fruffy]

Fixes #4147.

[jafingerhut]

I could approve this, but would prefer if someone closer to the C++ implementation could do so. @ChrisDodd would you have any time to take a look? The changes are short, but not sure if thinking about the possible consequences of the change are.

[fruffy]

I could approve this, but would prefer if someone closer to the C++ implementation could do so. @ChrisDodd would you have any time to take a look? The changes are short, but not sure if thinking about the possible consequences of the change are.

I do not know who is qualified to review these types of PR at this point.

[jafingerhut]

@vlstill Do you have some expertise in the files affected here such that you might be able to give this a thoughtful review?

[vlstill]

Seems like these were all workarounds for some pretty old GCC bugs. Since the comment mentions GCC 4.8 and since this compiles and passes test with GCC 9.4 (which is almost the oldest supported) I guess it is safe to delete the workarounds now. As for the boost macro, that should be safe too, there should be no real conflict between the get versions.

It would be nice to have at least basic unit test for get though.