Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build (only) container images for new PRs #3788

Merged
merged 1 commit into from
Dec 19, 2022
Merged

Build (only) container images for new PRs #3788

merged 1 commit into from
Dec 19, 2022

Conversation

davidbolvansky
Copy link
Contributor

@davidbolvansky davidbolvansky commented Dec 18, 2022

Detect problems sooner than after commit.

@davidbolvansky davidbolvansky marked this pull request as ready for review December 18, 2022 15:47
- main
branches: [ main ]
pull_request:
branches: [ main ]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trying to understand this? Doesn't this run on every pull request to main then?

Copy link
Contributor Author

@davidbolvansky davidbolvansky Dec 19, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is goal of this patch, to run it (only build step!) tor every new PR.

Currently container build runs only when patch is commited to main. (or via schedule)

@davidbolvansky davidbolvansky merged commit 21032b5 into p4lang:main Dec 19, 2022
@davidbolvansky davidbolvansky deleted the dbolvans/container_build_on_pr branch December 19, 2022 10:33
@davidbolvansky davidbolvansky restored the dbolvans/container_build_on_pr branch December 19, 2022 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants