Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise minimum required CMake version to Ubuntu 18.04 version. #3745

Merged
merged 2 commits into from
Dec 5, 2022

Conversation

fruffy
Copy link
Collaborator

@fruffy fruffy commented Nov 30, 2022

This PR is a proposal to raise the minimum required CMake version to 3.10.2, which is the default Ubuntu 18.04 version. Our CI only tests that version and support for older CMake versions can not be guaranteed.

The number is tentative, it could also be 3.6, since the current CMake has code that requires at least 3.6.

@apinski-cavium
Copy link

3.10.2 is the cmake version which is included in Ubuntu 1804 and it works just fine. Can you just increase the min version to 3.10.2 ?

@davidbolvansky
Copy link
Contributor

davidbolvansky commented Nov 30, 2022

p4c does not promise support for 18.04, nothing is tested on 18.

Or something changed and officially yes?

It would be great to make a decision - either fully support it or officially drop it.

@jafingerhut
Copy link
Contributor

This project is run by volunteers, pretty much, so it seems the word "official" might be a bit overstated.

That said, it seems worth not going out of our way to intentionally break builds on Ubuntu 18.04 until 2023-Apr when Ubuntu 18.04 reaches end of free long term support.

@apinski-cavium
Copy link

Note I am still use ubuntu 1804 and compile p4c and test just fine but will be moving next year to a newer ubuntu. The machine I use for main development is one I got in late 2018 and has been stable which is why I don't move as fast as some folks move to newer OS. I don't want to interrupt my flow with distro upgrades.

@davidbolvansky
Copy link
Contributor

davidbolvansky commented Dec 1, 2022

This project is run by volunteers, pretty much, so it seems the word "official" might be a bit overstated.

This is how it is written in README.

That said, it seems worth not going out of our way to intentionally break builds on Ubuntu 18.04 until 2023-Apr when Ubuntu 18.04 reaches end of free long term support.

This seems like a reasonable approach. At Intel we need to support U18 anyway even after this date, so it would be great to preserve support as long as possible and not intentionally break builds.

@davidbolvansky davidbolvansky changed the title Raise minimum required CMake version to Ubuntu 20.04 version. Raise minimum required CMake version to Ubuntu 18.04 version. Dec 1, 2022
@fruffy fruffy merged commit ee604f6 into main Dec 5, 2022
@fruffy fruffy deleted the fruffy/cmake_min branch December 8, 2022 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants