DPDK Backend : Minor fixes #3674

usha1830 · 2022-11-07T17:41:14Z

Error if learner table exists with non-exact match keys
Removed explicit from constructor with more than one parameters
Typo in condition check in context json generation
`4) Added new test

1) Error if learner table exists with non-exact match keys 2) Removed explicit from constructor with more than one paramater 3) Typo in condition check in context json generation 4) Added new test

mihaibudiu · 2022-11-07T18:04:17Z

backends/dpdk/dpdkContext.cpp

@@ -126,7 +126,7 @@ void DpdkContextGenerator::CollectTablesAndSetAttributes() {
            struct externAttributes externAttr;
            externAttr.externalName = ed->controlPlaneName();
            externAttr.externType = externTypeName;
-            if (externTypeName == "Counter" || "DirectCounter") {
+            if (externTypeName == "Counter" || externTypeName == "DirectCounter") {


should have caught this one earlier.

usha1830 · 2022-11-07T18:30:35Z

Fedora build is failing in installing dependencies

error: RPC failed; HTTP 503 curl 22 The requested URL returned error: 503
fatal: expected 'packfile'
Error: Process completed with exit code 128

DPDK Backend : Minor fixes

2a6e0f0

1) Error if learner table exists with non-exact match keys 2) Removed explicit from constructor with more than one paramater 3) Typo in condition check in context json generation 4) Added new test

mihaibudiu approved these changes Nov 7, 2022

View reviewed changes

mihaibudiu merged commit 8ee2e65 into p4lang:main Nov 8, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

DPDK Backend : Minor fixes #3674

DPDK Backend : Minor fixes #3674

usha1830 commented Nov 7, 2022

mihaibudiu Nov 7, 2022

usha1830 commented Nov 7, 2022

DPDK Backend : Minor fixes #3674

DPDK Backend : Minor fixes #3674

Conversation

usha1830 commented Nov 7, 2022

mihaibudiu Nov 7, 2022

Choose a reason for hiding this comment

usha1830 commented Nov 7, 2022