Allow implicit casts in switch labels; improve error message #3634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes #3623 |
| @@ -3836,6 +3836,8 @@ const IR::Node* TypeInference::postorder(IR::SwitchStatement* stat) { | |||
| auto lt = getType(c->label); | |||
| if (lt == nullptr) | |||
| continue; | |||
| if (auto se = lt->to<IR::Type_SerEnum>()) | |||
| lt = se->type; | |||
There was a problem hiding this comment.
I am not 100% sure with this change but will the following still work:
enum bit<4> e
{
a = 1
}
control c(in e v)
{
apply{
switch(v) {
e.a:
default: {}
}
}
}
and will this still be rejected:
enum bit<4> e
{
a = 1
}
control c(in e v)
{
apply{
switch(v) {
1:
default: {}
}
}
}
There was a problem hiding this comment.
I added theses test cases.
Signed-off-by: Mihai Budiu <mbudiu@vmware.com>
Signed-off-by: Mihai Budiu <mbudiu@vmware.com>
fruffy
approved these changes
Oct 30, 2022
| @@ -0,0 +1,6 @@ | |||
| issue3623-2.p4(8): [--Werror=type-error] error: 'v' with type 'e' cannot be compared to '4w1' with type 'bit<4>' | |||
There was a problem hiding this comment.
This error message are a little vague. Any way to make it more clear that this concerns a (ser)enum?
There was a problem hiding this comment.
Removing 'toString' will show better error messages. Just pushed this change.
Signed-off-by: Mihai Budiu <mbudiu@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Mihai Budiu mbudiu@vmware.com