Display external IPs on primary network interface #1070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
david-crespo
force-pushed
the
external-ip
branch
from
2cb595b
to
ffff5a4
Compare
zephraph
reviewed
Jul 26, 2022
Comment on lines
65
to
67
| await expectRowVisible(page, 'nic-2', ['nic-2', null, null, null, null, 'primary']) | ||
| await expectRowVisible(page, 'nic-2', ['nic-2', null, null, null, null, null, 'primary']) |
There was a problem hiding this comment.
Feel like we need a better way to do this. Key/value pairs for table names or something.
There was a problem hiding this comment.
const skip = (n: number) => new Array(5).fill(null)
await expectRowVisible(page, 'nic-2', ['nic-2', ...skip(5), 'primary'])😁
There was a problem hiding this comment.
this actually works ahaha
await expectRowVisible(page, 'nic-2', ['nic-2', , , , , , 'primary'])There was a problem hiding this comment.
I just mean more so the test doesn't need to be changed just because you add a new field.
There was a problem hiding this comment.
No, you’re totally right. I’ll give it a quick shot.
There was a problem hiding this comment.
You're gonna love 95fd19a
zephraph
approved these changes
Jul 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1066
Depends on oxidecomputer/omicron#1495, which is waiting on oxidecomputer/omicron#1478.