Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temp fix to make tests run #226

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Temp fix to make tests run #226

wants to merge 1 commit into from

Conversation

jwendel
Copy link

@jwendel jwendel commented Nov 12, 2018

This is a workaround to make issue #201 "work".

The problem seems to be that Test is marked as a "dir" tool, which means that the watcher will only trigger the Test tool if the watcher detects a change with a "dir". But the watching logic always will only trigger on file changes (at least most of the time).

This hack makes it so in the watcher, when calling tools, it just goes ahead and gets the dir of the changed file. That will cause the Test tool to be run.

This doesn't seem like an ideal fix, but it at least gets Test running again for people that like this tool

@sagarjauhari
Copy link

Thanks for investigating this bug and proposing a possible fix. But it feels like the ideal fix should be that Test shouldn't be marked as a 'dir' tool.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants