Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(linter/no-unused-vars): false positive when a variable used as a computed member property #5722

Merged
merged 1 commit into from
Sep 12, 2024
Merged

fix(linter/no-unused-vars): false positive when a variable used as a computed member property #5722

merged 1 commit into from
Sep 12, 2024

Conversation

Dunqing
Copy link
Member

@Dunqing Dunqing commented Sep 12, 2024 •
edited
Loading

close: #5671

@Dunqing Graphite App
Copy link
Member Author

Dunqing commented Sep 12, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @Dunqing and the rest of your teammates on Graphite Graphite

@github-actions github-actions bot added the A-linter Area - Linter label Sep 12, 2024
@graphite-app Graphite App
Copy link

graphite-app bot commented Sep 12, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Sep 12, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #5722 will not alter performance

Comparing 09-12-fix_linter_no-unused-vars_false_positive_when_a_variable_used_as_a_computed_member_property (e9c084a) with main (1dad9fa)

Summary

✅ 29 untouched benchmarks

@DonIsaac DonIsaac added C-bug Category - Bug 0-merge Merge with Graphite Merge Queue labels Sep 12, 2024
@graphite-app Graphite App
Copy link

graphite-app bot commented Sep 12, 2024 •
edited
Loading

Merge activity

  • Sep 12, 7:22 AM EDT: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Sep 12, 7:22 AM EDT: DonIsaac added this pull request to the Graphite merge queue.
  • Sep 12, 7:26 AM EDT: DonIsaac merged this pull request with the Graphite merge queue.

@DonIsaac DonIsaac force-pushed the 09-12-fix_linter_no-unused-vars_false_positive_when_a_variable_used_as_a_computed_member_property branch from 9684ba3 to e9c084a Compare September 12, 2024 11:23
@graphite-app graphite-app bot merged commit e9c084a into main Sep 12, 2024
26 checks passed
@graphite-app graphite-app bot deleted the 09-12-fix_linter_no-unused-vars_false_positive_when_a_variable_used_as_a_computed_member_property branch September 12, 2024 11:26
@Dunqing Dunqing mentioned this pull request Sep 13, 2024
Merged
Boshen pushed a commit that referenced this pull request Sep 13, 2024
@Dunqing
fix(linter/no-unused-vars): writes to members triggering false positi…
b4ed564 
…ve (#5744)

close: #5246

similar to #5722
@marvinhagemeister marvinhagemeister mentioned this pull request Sep 17, 2024
Closed
@oxc-bot oxc-bot mentioned this pull request Sep 18, 2024
Merged
Boshen added a commit that referenced this pull request Sep 18, 2024
@oxc-bot @Boshen @autofix-ci
release(oxlint): v0.9.6 (#5843)
65a1734 
## [0.9.6] - 2024-09-18

### Features

- 3bf7b24 linter: Make `typescript/no-duplicate-enum-values` a
`correctness` rule (#5810) (DonIsaac)
- 7799c06 linter/react: Implement `no-danger-with-children` rule (#5420)
(Cam McHenry)

### Bug Fixes

- f942485 linter: Remove all* remaining "Disallow <foo>" messages
(#5812) (DonIsaac)
- b5ad518 linter: Improve diagnostic messages for various lint rules
(#5808) (DonIsaac)
- 858f7af linter: Plugin prefix name for eslint-plugin-node (#5807)
(DonIsaac)
- 737ba1d linter: Fix some cases on ```AssignmentExpression``` for
```unicorn/consistent-function-scoping``` (#5675) (Arian94)
- 148c7a8 linter: Replace bitwise AND (&) with logical AND (&&) in
explici… (#5780) (kaykdm)
- b4ed564 linter/no-unused-vars: Writes to members triggering false
positive (#5744) (Dunqing)
- e9c084a linter/no-unused-vars: False positive when a variable used as
a computed member property (#5722) (Dunqing)

### Performance

- 3725d5d linter: Make all rules share a diagnostics vec (#5806)
(DonIsaac)
- e978567 linter: Shrink size of `DisableDirectives` (#5798) (DonIsaac)
- 1bfa515 linter: Remove redundant clone of diagnostics in context
(#5797) (DonIsaac)
- e413cad linter: Move shared context info to `ContextHost` (#5795)
(DonIsaac)

### Refactor

- 6dd6f7c ast: Change `Comment` struct (#5783) (Boshen)
- 7caae5b codegen: Add `GetSpan` requirement to `Gen` trait (#5772)
(Boshen)
- 026ee6a linter: Decouple module resolution from import plugin (#5829)
(dalaoshu)
- 50834bc linter: Move `override_rule` to `OxlintRules` (#5708)
(DonIsaac)
- a438743 linter: Move `OxlintConfig` to `Oxlintrc` (#5707) (DonIsaac)
- f61e8b5 linter: Impl serde and schemars traits for `LintPlugins`
(#5706) (DonIsaac)
- 20a7861 linter: Shorten `Option` syntax (#5735) (overlookmotel)
- d8b612c oxc_linter: Prefer pass Enum instead of str `no_plus_plus`
(#5730) (IWANABETHATGUY)
- cc0408b semantic: S/AstNodeId/NodeId (#5740) (Boshen)

---------

Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com>
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DonIsaac DonIsaac DonIsaac approved these changes

Assignees
No one assigned
Labels
0-merge Merge with Graphite Merge Queue A-linter Area - Linter C-bug Category - Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

no-unused-vars false positive on increment
2 participants
@Dunqing @DonIsaac