[tests-only][full-ci]Refactor webUILogin/adminBlocksUser.feature:20 to make it follow the current behaviour #8074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SwikritiT
changed the title
SwikritiT
changed the title
|
weird the screenshot shows that the user is navigated to the login page but locally for me they are navigated to the disabled page. Need to look further into it. |
SwikritiT
force-pushed
the
refactor-expected-to-fail-for-closed-issue
branch
from
fea04d7
to
33818c6
Compare
SwikritiT
force-pushed
the
refactor-expected-to-fail-for-closed-issue
branch
from
140b230
to
ae5c19d
Compare
|
Results for e2e-tests oC10 https://drone.owncloud.com/owncloud/web/30598/11/1 💥 To see the trace, please open the link in the console ...
npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/30598/tracing/upload-resources-in-personal-space-alice-2022-12-9-10-59-41.zip |
SwikritiT
force-pushed
the
refactor-expected-to-fail-for-closed-issue
branch
from
6636a1d
to
3bc76ad
Compare
SwikritiT
requested review from
saw-jan,
SagarGi,
phil-davis and
amrita-shrestha
SwikritiT
force-pushed
the
refactor-expected-to-fail-for-closed-issue
branch
2 times, most recently
from
cbb1fa7
to
80e69c1
Compare
saw-jan
reviewed
Dec 12, 2022
saw-jan
reviewed
Dec 12, 2022
SwikritiT
force-pushed
the
refactor-expected-to-fail-for-closed-issue
branch
from
d6fc429
to
a2c536e
Compare
… current behaviour use the user disabled page step change the selector fix lint try with single selector
SwikritiT
force-pushed
the
refactor-expected-to-fail-for-closed-issue
branch
from
a2c536e
to
025a777
Compare
saw-jan
approved these changes
Dec 13, 2022
|
Kudos, SonarCloud Quality Gate passed!
|
delete-merged-branch
bot
deleted the
refactor-expected-to-fail-for-closed-issue
branch
SwikritiT
added a commit
that referenced
this pull request
Dec 20, 2022
…o make it follow the current behaviour #8074
SwikritiT
added a commit
that referenced
this pull request
Dec 20, 2022
…ble branch (#8138) * Refactor test steps * [tests-only][full-ci]Refactor webUILogin/adminBlocksUser.feature:20 to make it follow the current behaviour #8074 * Remove tests from expected to failure linked to closed issue * Skip private link related tests on ocis * add notToImplementOnOCIS tag instead of skip on * Skip shares related tests in OCIS * Skip tests that open shares folder in ocis * Remove steps that browses to panel * update expected to fail
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The changed test was failing because it was not compatible with the current behavior of the system, this PR makes it work according to the current behavior and removes closed issue #4795 from the expected to fail.
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist:
Open tasks: