Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add origin checks to all Draw.io events #7941

Merged
merged 3 commits into from
Nov 14, 2022
Merged

Conversation

JammingBen
Copy link
Collaborator

Description

Origin checks have been added to all Draw.io events due to security reasons.

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Security
  • Tests

@JammingBen JammingBen self-assigned this Nov 9, 2022
@JammingBen JammingBen changed the base branch from master to stable-6.0 November 9, 2022 11:00
@@ -64,7 +64,7 @@ export default defineComponent({
watch: {
currentFileContext: {
handler: function () {
this.load()
this.checkPermissions()
Copy link
Collaborator Author

@JammingBen JammingBen Nov 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fyi No need to call load() here, it will be called later anyways. checkPermissions() is sufficient.

@sonarcloud
Copy link

sonarcloud bot commented Nov 14, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@JammingBen JammingBen merged commit c83d3cc into stable-6.0 Nov 14, 2022
@delete-merged-branch delete-merged-branch bot deleted the add-event-origin-checks branch November 14, 2022 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add origin check to events
4 participants