feat: respect denial capability #7892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
kulmann
force-pushed
the
share-denial-capability
branch
from
ef8ee04
to
0dbe939
Compare
kulmann
commented
Nov 2, 2022
| this.selectedRole = PeopleShareRoles.list( | ||
| this.resource.isFolder, | ||
| this.resource.canDeny() | ||
| this.hasRoleCustomPermissions, |
There was a problem hiding this comment.
This was actually a bug, because canDeny was passed as hasCustom param for the list method.
|
Kudos, SonarCloud Quality Gate passed! |
73 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Since owncloud/ocis#4903 has been merged today, web shows the experimental sharing denial feature (via the "No access" role) by default. oCIS added a capability to announce to clients whether or not the feature is available and should be shown to users. With this PR web now respects that capability.
Types of changes
Checklist: