Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable share renaming #7865

Merged
merged 2 commits into from
Nov 2, 2022
Merged

Disable share renaming #7865

merged 2 commits into from
Nov 2, 2022

Conversation

JammingBen
Copy link
Collaborator

@JammingBen JammingBen commented Oct 25, 2022 •
edited
Loading

Description

Renaming of shares has been disabled temporarily until it works as expected. Also see owncloud/ocis#4866

Note: We need to merge this before GA if the issue has not been solved until then.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

@sonarcloud
Copy link

sonarcloud bot commented Nov 2, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

50.0% 50.0% Coverage
0.0% 0.0% Duplication

kulmann
kulmann approved these changes Nov 2, 2022
View reviewed changes
Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kulmann kulmann marked this pull request as ready for review November 2, 2022 10:18
@kulmann kulmann merged commit 28f3f01 into master Nov 2, 2022
@delete-merged-branch delete-merged-branch bot deleted the disable-share-renaming branch November 2, 2022 10:26
@micbar micbar mentioned this pull request Nov 25, 2022
Closed
73 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kulmann kulmann kulmann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JammingBen @kulmann