Redesign shared with list #7252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
|
Results for oC10SharingIntUsers1 https://drone.owncloud.com/owncloud/web/26916/30/1 💥 The acceptance tests failed on retry. Please find the screenshots inside ...
webUISharingInternalUsersToRootCollaborator-shareWithUsers_feature-L74.pngwebUISharingInternalUsersToRootCollaborator-shareWithUsers_feature-L75.png |
kulmann
requested changes
Jul 18, 2022
There was a problem hiding this comment.
Looks really nice and clean, I like it. 👍 Small nitpicks about the content of the drop (see comments). And making the acceptance tests pass will be fun I guess.
Noticed another small UI glitch: when you add or remove an expiration date, there is a line height change by approx. 1px (look at the space between the name and the role of the sharee).
packages/web-app-files/src/components/SideBar/Shares/Collaborators/ListItem.vue
Outdated
Show resolved
Hide resolved
packages/web-app-files/src/components/SideBar/Shares/Collaborators/ListItem.vue
Outdated
Show resolved
Hide resolved
AlexAndBear
changed the title
added 2 commits
July 19, 2022 10:40
AlexAndBear
changed the title
kulmann
reviewed
Jul 20, 2022
| Enhancement: Redesign shared with list | ||
|
|
||
| We've redesigned the shared with list, to archive more spacing and a better user experience. | ||
| We've also fixed a bug, where the role in a sub share wasn't shown. |
There was a problem hiding this comment.
Suggested change
| We've also fixed a bug, where the role in a sub share wasn't shown. | |
| We've also fixed a bug, where the role in a child of a share wasn't shown. |
packages/web-app-files/src/components/SideBar/Shares/Collaborators/ListItem.vue
Show resolved
Hide resolved
|
SonarCloud Quality Gate failed. |
26 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist:
Open tasks: