[full-ci] feat(public-links): archive downloads in public links #5924

fschade · 2021-10-18T12:43:47Z

Description

We introduced archive downloads and app providers in the last weeks, in perspective of getting this out fast we decided to ship those features in small units.

Currently it is not possible to retrieve capabilities from public links which is problematic and prevents usage of features like archiving and app providers.

This is included and now loads the capabilities in public links with password protection and without.
After that was done it was needed to update the launch process of web which now also have a new livecycle hook (userReady).

This also works if the runtime user provisioning step is skipped and another application takes care, in our case the files app.
This shifts responsibility to the individual app and for now is a highly experimental api which should not be used outside of this scope.

some hacky parts are included which needs a refactoring & new design of how applications get loaded, provisioned and rendered. Different topic.

Following features benefit from it:

create archive from an public link
create archive from an password protected public link (currently disabled because ocis implications)
open a file with an app provider from an public link
open a file with an app provider from an password protected public link
retrieving capabilities for public links

it also fixes a bug where the capabilities where not available right after a fresh login, we had to do a hard reload before this to work around it.

Related Issue

Motivation and Context

be able to use new features for public links also

How Has This Been Tested?

local ocis installation

Screenshots (if appropriate):

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)
Technical debt
Tests

Checklist:

Code changes
Unit tests added
Acceptance tests added
Documentation ticket raised:

Open tasks:

write tests
test more
changelog, TODO is probbally not the best idea ;)

update-docs · 2021-10-18T12:43:51Z

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

ownclouders · 2021-10-19T16:10:04Z

Results for oC10SharingAccept https://drone.owncloud.com/owncloud/web/19809/11/1
💥 The acceptance tests pipeline failed. The build has been cancelled.

ownclouders · 2021-10-21T19:03:59Z

Results for oCISBasic https://drone.owncloud.com/owncloud/web/19864/49/1
💥 The acceptance tests pipeline failed. The build has been cancelled.

labkode · 2021-10-22T05:42:53Z

create archive from an password protected public link (currently disabled because ocis implications)

@fschade can you give a pointer to this limitation?

wkloucek · 2021-10-22T06:30:53Z

I did not succeed in the bookmark usecase for the app provider:

open a file in X (OnlyOffice / Collabora / CodiMD) from a public link and copy the URL (looks like this: https://ocis.owncloud.test/#/external/Collabora/MTI4NGQyMzgtYWE5Mi00MmNlLWJkYzQtMGIwMDAwMDA5MTU3OmU4ZWRlODQ3LWEwYTUtNGEwNC04Y2UxLWZjNzU4MjRmOGMwNw==?public-token=plcHEpAChHAHzZS)
open the URL in a new browser / incognito tab
enjoy the infinite loading spinnner. I would expect the document to open. The console gives me TypeError: Cannot read properties of undefined (reading 'app_providers')

wkloucek · 2021-10-22T06:38:16Z

open a file with an app provider from an password protected public link

Is this already supposed to work?
I didn't succeed with this. I get a basic auth popup and if i cancel that, I don't have the apps in the context menues.

Peek.2021-10-22.08-37.mp4

wkloucek · 2021-10-22T06:44:39Z

Nothing related to Web, but I am currently able to edit and save changes to files I received with a "viewer" public link. This needs to be fixed Reva.

wkloucek · 2021-10-22T06:47:11Z

Also the public token auth impersonates the original sharer and therefore the apps show the original sharer as user. It should be highlighted that it isn't the original sharer but an anonymous user granted by the original sharer.

labkode · 2021-10-22T06:56:25Z

Nothing related to Web, but I am currently able to edit and save changes to files I received with a "viewer" public link. This needs to be fixed Reva.

@C0rby can you look into this one?

fschade · 2021-10-22T07:45:04Z

open a file with an app provider from an password protected public link

Is this already supposed to work? I didn't succeed with this. I get a basic auth popup and if i cancel that, I don't have the apps in the context menues.

Peek.2021-10-22.08-37.mp4

good point, i only tested it to open the link after files app showed up at least once, this is a bug. Thanks

fschade · 2021-10-22T08:35:05Z

@wkloucek the bookmark thing should work now.
@labkode we are at the moment not able to use the archiver from a public link, we have no way for now to pass the publikPassword to the backend.

Same could apply for appProviders if the link is bookmarked and the user haven't already provided his password

CLAassistant · 2021-11-04T14:01:16Z

All committers have signed the CLA.

ownclouders · 2021-11-04T14:19:49Z

Results for oCISSharingInternalUsers2 https://drone.owncloud.com/owncloud/web/20042/58/1
💥 The acceptance tests pipeline failed. The build has been cancelled.

ownclouders · 2021-11-04T17:02:29Z

Results for oCISSharingInternalUsers2 https://drone.owncloud.com/owncloud/web/20048/58/1
💥 The acceptance tests pipeline failed. The build has been cancelled.

ownclouders · 2021-11-04T19:07:38Z

Results for oCISFiles2 https://drone.owncloud.com/owncloud/web/20049/55/1
💥 The acceptance tests pipeline failed. The build has been cancelled.

kulmann

LGTM, hacky parts are ok for now

update the launch process to support late loaded data like capabilities which is needed for doing things like archiving on public links

… happen if the url is bookmarked

ownclouders · 2021-11-08T09:28:15Z

Results for oC10Files1 https://drone.owncloud.com/owncloud/web/20109/15/1
The following scenarios passed on retry:

webUIFilesActionMenu/versions.feature:15

The right sidebar now only takes 1/3 of the width on medium and large viewports and 1/4 of the width on extra large viewports. It doesn't need more horizontal space.

…ion dates in shares

This reverts commit 9dcce09.

wkloucek · 2021-11-08T12:51:30Z

Nothing related to Web, but I am currently able to edit and save changes to files I received with a "viewer" public link. This needs to be fixed Reva.

@C0rby can you look into this one?

Will be fixed in cs3org/reva#2214

sonarcloud · 2021-11-08T12:52:28Z

SonarCloud Quality Gate failed.

0 Bugs
0 Vulnerabilities
0 Security Hotspots
7 Code Smells

10.4% Coverage
0.0% Duplication

ownclouders · 2021-11-08T13:05:34Z

Results for oC10Sharing1 https://drone.owncloud.com/owncloud/web/20122/19/1
The following scenarios passed on retry:

webUISharingExpirationDate/shareWithExpirationDate.feature:14

diocas · 2021-11-09T15:59:43Z

With this PR merges, does that mean that all the others (#5863 #2479) can be closed?
Does this require anything special from the backend? What I'm seeing from a quick test, is a call to capabilities without any token (which in our case falls back to basic auth). I cancel the auth and the page loads, but then I don't see any call to the apps provider, hence no apps.
(using my text-editor app it redirects me to the idp, I guess I need to set the route as non authenticated? I already have a special route for public-links)

wkloucek · 2021-11-09T20:06:21Z

With this PR merges, does that mean that all the others (#5863 #2479) can be closed? Does this require anything special from the backend? What I'm seeing from a quick test, is a call to capabilities without any token (which in our case falls back to basic auth). I cancel the auth and the page loads, but then I don't see any call to the apps provider, hence no apps. (using my text-editor app it redirects me to the idp, I guess I need to set the route as non authenticated? I already have a special route for public-links)

cs3org/reva#2143 and owncloud/ocis#2536 needs to be there. The authentication for the capabilities request is done with the public-token header. A curl example would be curl 'https://ocis.ocis-traefik.latest.owncloud.works/ocs/v1.php/cloud/capabilities?format=json' -H 'PUBLIC-TOKEN:KvhXJieGpENGXgQ' but KvhXJieGpENGXgQ needs to be a valid / existing public link token

diocas · 2021-11-09T21:17:32Z

@ishank011

wkloucek · 2021-11-10T06:45:50Z

@ishank011 please consider using it in combination with cs3org/reva#2214 only

ishank011 · 2021-11-10T11:05:06Z

Thanks @wkloucek! I'll review that PR asap

fschade · 2021-11-10T17:26:45Z

@diocas please note this only works for public links without password, #5863 is used as tracking for public links with password

fschade force-pushed the public-token-features branch 2 times, most recently from 056cd7b to 51f246a Compare October 21, 2021 18:38

kulmann force-pushed the public-token-features branch from 2759791 to b79add4 Compare October 29, 2021 13:35

wkloucek mentioned this pull request Nov 3, 2021

state of oCIS office integration owncloud/ocis#2721

Closed

fschade force-pushed the public-token-features branch from 23c2b50 to d7839d3 Compare November 4, 2021 14:04

kulmann changed the title ~~[WIP] feat(public-links): archive downloads in public links~~ [full-ci] feat(public-links): archive downloads in public links Nov 5, 2021

kulmann marked this pull request as ready for review November 5, 2021 11:37

kulmann requested review from kulmann and pascalwengerter as code owners November 5, 2021 11:37

kulmann force-pushed the public-token-features branch from d7839d3 to 4408b47 Compare November 5, 2021 11:44

kulmann approved these changes Nov 5, 2021

View reviewed changes

fschade and others added 4 commits November 5, 2021 14:17

feat(public-links): retrieve capabilities early

e9decfb

update the launch process to support late loaded data like capabilities which is needed for doing things like archiving on public links

fetch capabilities in external app if not already present, this could…

9824311

… happen if the url is bookmarked

Add changelog

4110e4c

fix unit tests

6dbda47

kulmann force-pushed the public-token-features branch from da8e39c to 6ced5fc Compare November 5, 2021 15:27

pascalwengerter mentioned this pull request Nov 8, 2021

[full-ci] debugging tests of #5924 #5987

Closed

10 tasks

fix falsy mimetype access

efd445b

fschade force-pushed the public-token-features branch from 3ebe54c to efd445b Compare November 8, 2021 10:24

kulmann and others added 11 commits November 8, 2021 13:43

Reduce sidebar width in files app

ff6b536

The right sidebar now only takes 1/3 of the width on medium and large viewports and 1/4 of the width on extra large viewports. It doesn't need more horizontal space.

Truncate filename in right sidebar if needed

f41e7fa

Automated changelog update [skip ci]

5b2e836

Remove vue-axe to reduce bundle size

c7263ad

[Tests-Only] refactor date selection in integration tests for expirat…

96d6eff

…ion dates in shares

rename _chunks folder to chunks folder

708ac00

add changelog

774d2a2

Automated changelog update [skip ci]

cec3c12

revert ocis commitid to check ci

e0d195b

Revert "Automated changelog update [skip ci]"

6f643b2

This reverts commit 9dcce09.

fix ci issues

964415d

fschade merged commit 936a57b into master Nov 8, 2021

delete-merged-branch bot deleted the public-token-features branch November 8, 2021 13:29

kulmann mentioned this pull request Nov 11, 2021

Allow archive download on public links #5912

Closed

10 tasks

phil-davis mentioned this pull request Nov 12, 2021

Cannot login to locally hosted web manually (latest commit) #6010

Closed

owncloud deleted a comment from rizu1234565 Aug 22, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[full-ci] feat(public-links): archive downloads in public links #5924

[full-ci] feat(public-links): archive downloads in public links #5924

fschade commented Oct 18, 2021 •

edited by kulmann

Loading

update-docs bot commented Oct 18, 2021

ownclouders commented Oct 19, 2021

ownclouders commented Oct 21, 2021

labkode commented Oct 22, 2021

wkloucek commented Oct 22, 2021

wkloucek commented Oct 22, 2021

wkloucek commented Oct 22, 2021

wkloucek commented Oct 22, 2021

labkode commented Oct 22, 2021

fschade commented Oct 22, 2021

fschade commented Oct 22, 2021

CLAassistant commented Nov 4, 2021 •

edited

Loading

ownclouders commented Nov 4, 2021

ownclouders commented Nov 4, 2021

ownclouders commented Nov 4, 2021

kulmann left a comment

ownclouders commented Nov 8, 2021

wkloucek commented Nov 8, 2021

sonarcloud bot commented Nov 8, 2021

ownclouders commented Nov 8, 2021

diocas commented Nov 9, 2021 •

edited

Loading

wkloucek commented Nov 9, 2021

diocas commented Nov 9, 2021

wkloucek commented Nov 10, 2021

ishank011 commented Nov 10, 2021

fschade commented Nov 10, 2021

[full-ci] feat(public-links): archive downloads in public links #5924

[full-ci] feat(public-links): archive downloads in public links #5924

Conversation

fschade commented Oct 18, 2021 • edited by kulmann Loading

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

Checklist:

Open tasks:

update-docs bot commented Oct 18, 2021

ownclouders commented Oct 19, 2021

ownclouders commented Oct 21, 2021

labkode commented Oct 22, 2021

wkloucek commented Oct 22, 2021

wkloucek commented Oct 22, 2021

wkloucek commented Oct 22, 2021

wkloucek commented Oct 22, 2021

labkode commented Oct 22, 2021

fschade commented Oct 22, 2021

fschade commented Oct 22, 2021

CLAassistant commented Nov 4, 2021 • edited Loading

ownclouders commented Nov 4, 2021

ownclouders commented Nov 4, 2021

ownclouders commented Nov 4, 2021

kulmann left a comment

Choose a reason for hiding this comment

ownclouders commented Nov 8, 2021

wkloucek commented Nov 8, 2021

sonarcloud bot commented Nov 8, 2021

ownclouders commented Nov 8, 2021

diocas commented Nov 9, 2021 • edited Loading

wkloucek commented Nov 9, 2021

diocas commented Nov 9, 2021

wkloucek commented Nov 10, 2021

ishank011 commented Nov 10, 2021

fschade commented Nov 10, 2021

fschade commented Oct 18, 2021 •

edited by kulmann

Loading

CLAassistant commented Nov 4, 2021 •

edited

Loading

diocas commented Nov 9, 2021 •

edited

Loading