Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tests-Only] Dont crash the test build if dav properties are not found #5511

Merged
merged 1 commit into from
Jul 12, 2021

Conversation

dpakach
Copy link
Contributor

@dpakach dpakach commented Jul 12, 2021

Description

Dont crash the test build if dav properties are not found
So that we dont get crashes such as https://drone.owncloud.com/owncloud/ocis/5976/52/6

Related Issue

  • Fixes tests on ocis

Motivation and Context

How Has This Been Tested?

🤖

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • ...

@dpakach dpakach requested a review from fschade as a code owner July 12, 2021 11:35
@dpakach dpakach self-assigned this Jul 12, 2021
@sonarcloud
Copy link

sonarcloud bot commented Jul 12, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@phil-davis phil-davis merged commit 20ab232 into master Jul 12, 2021
@delete-merged-branch delete-merged-branch bot deleted the dont-crash-on-failure branch July 12, 2021 12:14
@phil-davis
Copy link
Contributor

The web commit id in OCIS is being updated in owncloud/ocis#2287 so that this code will bbe in use in OCIS CI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants