Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix indirect via-share in collaborator sidebar section #5122

Merged
merged 1 commit into from
May 18, 2021

Conversation

pascalwengerter
Copy link
Contributor

@pascalwengerter pascalwengerter commented May 18, 2021

Description

The "Via" button in the collaborators according section in the sidebar sends you to the parent of the share entry, while it actually should send you the to share entry itself.

Related Issue

@pascalwengerter pascalwengerter changed the title Fix indirect via-share in collaborator sidebar section [Needs Reva update] Fix indirect via-share in collaborator & link sidebar section May 18, 2021
@pascalwengerter pascalwengerter changed the title [Needs Reva update] Fix indirect via-share in collaborator & link sidebar section Fix indirect via-share in collaborator sidebar section May 18, 2021
Copy link
Contributor

@LukasHirt LukasHirt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@pascalwengerter pascalwengerter merged commit a23ebbf into master May 18, 2021
@delete-merged-branch delete-merged-branch bot deleted the 18052021_fix-sidebar-via-path branch May 18, 2021 15:25
diocas pushed a commit to cernbox/web that referenced this pull request May 19, 2021
…ia-path

Fix indirect via-share in collaborator sidebar section
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The via button sends you to the parent of the share entry
2 participants