Skip to content

Commit

Permalink
Merge branch 'master' into master-merge-#1
Browse files Browse the repository at this point in the history
  • Loading branch information
Jan committed Sep 8, 2022
2 parents e2633fa + 24bf6d3 commit ef4e485
Show file tree
Hide file tree
Showing 285 changed files with 4,631 additions and 3,948 deletions.
448 changes: 228 additions & 220 deletions .drone.star

Large diffs are not rendered by default.

354 changes: 339 additions & 15 deletions CHANGELOG.md

Large diffs are not rendered by default.

Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
Bugfix: Allow uploads outside of user's home despite quota being exceeded

We've fixed a bug where a user was not able to upload a file in a share or space
when the personal home quota was exceeded.
We also show a message in the upload details if an upload to a share fails because the share owner's
quota is exceeded.

https://github.com/owncloud/web/pull/7522
https://github.com/owncloud/web/issues/6318
https://github.com/owncloud/web/issues/5817
5 changes: 5 additions & 0 deletions changelog/unreleased/bugfix-default-to-user-context
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
Bugfix: Default to user context

We've fixed a bug where routes without explicit `auth` requirement (i.e. user context) and without any context route in the URL were recognized as neither user-context nor public-link-context. In such situations we now expect that the session requires a user and redirect to the login page.

https://github.com/owncloud/web/pull/7437
5 changes: 5 additions & 0 deletions changelog/unreleased/bugfix-drag-drop-no-selection
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
Bugfix: Dragging a file causes no selection

We've fixed a bug that caused no selection when dragging a file.

https://github.com/owncloud/web/pull/7473
7 changes: 7 additions & 0 deletions changelog/unreleased/bugfix-file-name-in-text-editor
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
Bugfix: File name in text editor

We've fixed a bug in the text editor where the UUID of a shared resource was being displayed instead of the file name.

https://github.com/owncloud/web/pull/7516
https://github.com/owncloud/web/issues/7292
https://github.com/owncloud/web/pull/7518
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
Bugfix: File size not updated while restoring file version

We've fixed a bug where the file size was not updated in the files table or side bar while restoring a file version.

https://github.com/owncloud/web/pull/7469
https://github.com/owncloud/web/issues/7438
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
Bugfix: Fix right sidebar content on small screens

We've fixed the right sidebar content on small screens because some screen sizes caused the content to flow out of the screen. Things that have been done to achieve this:

* Selection info has been removed.
* Labels of the batch actions will hide on screens <1280px if the sidebar is open.

https://github.com/owncloud/web/issues/7498
https://github.com/owncloud/web/pull/7508
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
Bugfix: Improve keyboard shortcuts copy/cut files

We've changed the Ctrl+X message to 'Cut to Clipboard' from 'Copied to Clipboard'

https://github.com/owncloud/web/issues/7455
https://github.com/owncloud/web/pull/7492
6 changes: 6 additions & 0 deletions changelog/unreleased/bugfix-keyboard-not-working-spaces
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
Bugfix: Paste action (keyboard) not working in project spaces

We've fixed a bug which caused the user to be unable to paste in project spaces.

https://github.com/owncloud/web/issues/7510
https://github.com/owncloud/web/pull/7514
6 changes: 6 additions & 0 deletions changelog/unreleased/bugfix-left-sidebar-app-switch
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
Bugfix: Left sidebar when switching apps

We've fixed a bug where the active state of the left sidebar would glitch visually when switching apps.

https://github.com/owncloud/web/issues/7526
https://github.com/owncloud/web/pull/7529
6 changes: 6 additions & 0 deletions changelog/unreleased/bugfix-load-only-supported-thumbnails
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
Bugfix: Load only supported thumbnails (configurable)

We've fixed a bug where web was trying to load thumbnails for files that are not supported.
Due to configurable values, we avoid unnecessary requests.

https://github.com/owncloud/web/pull/7474
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
Bugfix: Prevent unnecessary PROPFIND request during upload

We've removed the unnecessary PROPFIND request at the start of each upload, increasing upload performance especially in larger folders.

https://github.com/owncloud/web/issues/7486
https://github.com/owncloud/web/pull/7488
6 changes: 6 additions & 0 deletions changelog/unreleased/bugfix-redirect-space-access-removal
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
Bugfix: Redirect after removing self from space members

When a user removes themselves from the members of a project space we now properly redirect to the project spaces overviewe page instead of showing an error message.

https://github.com/owncloud/web/issues/7534
https://github.com/owncloud/web/pull/7576
8 changes: 8 additions & 0 deletions changelog/unreleased/bugfix-search-share-representation
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
Bugfix: Search share representation

We've fixed a bug, where shares in the search were not displayed correctly and clicking on the respective
item did not open the default action or redirect to the correct share route.

https://github.com/owncloud/web/pull/7560
https://github.com/owncloud/web/issues/7043

6 changes: 6 additions & 0 deletions changelog/unreleased/bugfix-shared-via-indicator-for-links
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
Bugfix: "Shared via"-indicator for links

We've fixed a bug where the "Shared via"-indicator would be empty or not be displayed at all for public links.

https://github.com/owncloud/web/issues/7478
https://github.com/owncloud/web/pull/7479
6 changes: 6 additions & 0 deletions changelog/unreleased/bugfix-sidebar-for-current-folder
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
Bugfix: Sidebar for current folder

We've fixed a bug where the right sidebar for the current folder could not be opened when another resource was selected.

https://github.com/owncloud/web/issues/7519
https://github.com/owncloud/web/pull/7527
6 changes: 6 additions & 0 deletions changelog/unreleased/bugfix-space-image-sidebar
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
Bugfix: Missing space image in sidebar

We've fixed a bug where the image of a space was not showing in the sidebar.

https://github.com/owncloud/web/issues/7480
https://github.com/owncloud/web/pull/7481
6 changes: 6 additions & 0 deletions changelog/unreleased/bugfix-space-share-actions
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
Bugfix: Hide share actions for space viewers/editors

We've fixed a bug where viewers and editors of a space could see the actions to edit and remove shares. We've also improved the error handling when something goes wrong while editing/removing shares.

https://github.com/owncloud/web/issues/7436
https://github.com/owncloud/web/pull/7470
8 changes: 8 additions & 0 deletions changelog/unreleased/bugfix-stuck-after-session-expired
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
Bugfix: Stuck After Session Expired

We've fixed exit link to redirect to login once session expires

We've removed the logout click handler and created a new logout component

https://github.com/owncloud/web/issues/7453
https://github.com/owncloud/web/pull/7491
3 changes: 3 additions & 0 deletions changelog/unreleased/bugfix-typo-reading-capabilities-pl
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
Bugfix: Typo when reading public links capabilities

https://github.com/owncloud/web/pull/7595
Original file line number Diff line number Diff line change
Expand Up @@ -4,3 +4,4 @@ We've fixed a bug, where closing the side bar in the user management app threw a
when a group or user was selected.

https://github.com/owncloud/web/pull/7445
https://github.com/owncloud/web/pull/7461
7 changes: 7 additions & 0 deletions changelog/unreleased/enhancement-left-sidebar-hover
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
Enhancement: Left sidebar hover effect

We've added a hover effect to the left sidebar items.

https://github.com/owncloud/web/issues/7540
https://github.com/owncloud/web/pull/7567
https://github.com/owncloud/web/pull/7575
1 change: 1 addition & 0 deletions changelog/unreleased/enhancement-permissionless-links
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,5 @@ Enhancement: Permissionless (internal) link shares
We have added the possibility to create alias link shares for internal usage when the backend is capable of handling them.

https://github.com/owncloud/web/pull/7133
https://github.com/owncloud/web/pull/7505
https://github.com/owncloud/web/issues/6844
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
Enhancement: Propose unique file name while creating a new file

We're proposing unique file names when creating a new file or folder via the 'New' file menu.

https://github.com/owncloud/web/pull/7555
https://github.com/owncloud/web/issues/7539
1 change: 1 addition & 0 deletions changelog/unreleased/enhancement-redesign-shared-with-list
Original file line number Diff line number Diff line change
Expand Up @@ -8,5 +8,6 @@ https://github.com/owncloud/web/pull/7310
https://github.com/owncloud/web/pull/7315
https://github.com/owncloud/web/pull/7372
https://github.com/owncloud/web/pull/7402
https://github.com/owncloud/web/pull/7475
https://github.com/owncloud/web/issues/7110
https://github.com/owncloud/web/issues/7340
7 changes: 7 additions & 0 deletions changelog/unreleased/enhancement-reduce-pagination-options
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
Enhancement: Reduce pagination options

We've reduced the pagination options by removing the options to display 1000 and all files. These may be added again later after further improving the files table performance.

https://github.com/owncloud/web/issues/7038
https://github.com/owncloud/web/pull/7597

Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
Enhancement: Remove clickOutside directive

We've removed the clickOutside directive because it isn't used anymore

https://github.com/owncloud/web/pull/7584
https://github.com/owncloud/web/issues/7572

Original file line number Diff line number Diff line change
Expand Up @@ -4,4 +4,5 @@ We've replaced the locationpicker in batchactions and contextmenu with
the new cut/copy/paste clipboard actions.

https://github.com/owncloud/web/pull/7309
https://github.com/owncloud/web/pull/7503
https://github.com/owncloud/web/issues/6892
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
Enhancement: Add resource name to the WebDAV properties

We've added the resource name to the WebDAV properties.

https://github.com/owncloud/web/pull/7485
5 changes: 5 additions & 0 deletions changelog/unreleased/enhancement-scroll-to-without-sidebar
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
Enhancement: Don't open right sidebar from private links

We've changed the behaviour of the web ui to not open the right sidebar anymore when the URL contains a "scrollTo" option. We still select the file and scroll it into the view, but opening the right sidebar felt very invasive, so we now leave that choice to the user.

https://github.com/owncloud/web/pull/7559
10 changes: 10 additions & 0 deletions changelog/unreleased/enhancement-search-improvements
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
Enhancement: Search improvements

We've improved the search, it will show now if no results according to term was found or if the results exceeds the
search limit.
We've also navigate to the last page while clicking the x in the search input field.

https://github.com/owncloud/web/pull/7586
https://github.com/owncloud/web/issues/5644
https://github.com/owncloud/web/issues/7587

7 changes: 7 additions & 0 deletions changelog/unreleased/enhancement-simplify-mime-type-checking
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
Enhancement: Simplify mime type checking

We've removed the dependency to GuzzleHttp from our oc10 app package. It was used for mime type checking only. Instead we now rely on a mime type checker that is already bundled with oc10 core.
IMPORTANT: this enhancement is needed to reach compatibility with oc10.11 and maintain backwards compatibility with oc prior to oc10.11. This would not be easily doable when still relying on GuzzleHttp because its major version was updated from 5 to 7 in oc10.11.

https://github.com/owncloud/web/pull/7605
https://github.com/owncloud/web/pull/5933
7 changes: 7 additions & 0 deletions changelog/unreleased/enhancement-streamline-ui-sizings
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
Enhancement: Streamline UI sizings

We've streamlined the font sizes and some other size related options to let the web UI appear a bit more condensed. In addition to that we've chosen a new font family for the UI ("Inter") which is embedded into the ownCloud Design System by default now.

https://github.com/owncloud/web/pull/7363
https://github.com/owncloud/web/issues/7333
https://github.com/owncloud/owncloud-design-system/pull/2270
47 changes: 28 additions & 19 deletions changelog/unreleased/enhancement-update-ods
Original file line number Diff line number Diff line change
@@ -1,22 +1,31 @@
Enhancement: Update ODS to v14.0.0-alpha.12
Enhancement: Update ODS to v14.0.0-alpha.17

We updated the ownCloud Design System to version 14.0.0-alpha.12. Please refer to the full changelog in the ODS release (linked) for more details. Summary:
We updated the ownCloud Design System to version 14.0.0-alpha.17. Please refer to the full changelog in the ODS release (linked) for more details. Summary:

- Bugfix - Remove click event on OcIcon: #2216
- Bugfix - Lazy loading render performance: #2260
- Bugfix - Omit special characters in user avatar initials: #2267
- Bugfix - Avatar link icon: #2269
- Bugfix - Remove width shrinking of the ocAvatarItem: #2242
- Change - Remove OcAlert component: #2210
- Change - Remove transition animations: #2210
- Change - Revamp animations: #2210
- Change - OcTable emit event data on row click: #2218
- Enhancement - OcCheckbox add outline: #2218
- Enhancement - Progress bar indeterminate state: #2200
- Enhancement - Redesign notifications: #2210
- Enhancement - Use oc colors for selected background and deselect icon: #2262
- Enhancement - Adjust avatar font weight from bold to normal: #2275
- Enhancement - Add offset property to the drop component: #2276
* Bugfix - Omit special characters in user avatar initials: [#2070](https://github.com/owncloud/owncloud-design-system/issues/2070)
* Bugfix - Avatar link icon: [#2269](https://github.com/owncloud/owncloud-design-system/pull/2269)
* Bugfix - Firefox drag & drop move of folders not possible: [#7495](https://github.com/owncloud/web/issues/7495)
* Bugfix - Lazy loading render performance: [#2260](https://github.com/owncloud/owncloud-design-system/pull/2260)
* Bugfix - Remove width shrinking of the ocAvatarItem: [#2241](https://github.com/owncloud/owncloud-design-system/issues/2241)
* Bugfix - Remove click event on OcIcon: [#2216](https://github.com/owncloud/owncloud-design-system/pull/2216)
* Change - Redesign contextual helper: [#2271](https://github.com/owncloud/owncloud-design-system/pull/2271)
* Change - Remove OcAlert component: [#2210](https://github.com/owncloud/owncloud-design-system/pull/2210)
* Change - Remove transition animations: [#2210](https://github.com/owncloud/owncloud-design-system/pull/2210)
* Change - Revamp animations: [#2210](https://github.com/owncloud/owncloud-design-system/pull/2210)
* Change - OcTable emit event data on row click: [#2218](https://github.com/owncloud/owncloud-design-system/pull/2218)
* Enhancement - Add nestedd drop functionality: [#2238](https://github.com/owncloud/owncloud-design-system/issues/2238)
* Enhancement - Add OcInfoDrop: [#2286](https://github.com/owncloud/owncloud-design-system/pull/2286)
* Enhancement - Add rounded prop to OcTag: [#2284](https://github.com/owncloud/owncloud-design-system/pull/2284)
* Enhancement - Adjust avatar font weight from bold to normal: [#2275](https://github.com/owncloud/owncloud-design-system/pull/2275)
* Enhancement - Align breadcrumb context menu with regular context menu: [#2296](https://github.com/owncloud/owncloud-design-system/pull/2296)
* Enhancement - OcCheckbox add outline: [#2218](https://github.com/owncloud/owncloud-design-system/pull/2218)
* Enhancement - Add offset property to the drop component: [#7335](https://github.com/owncloud/web/issues/7335)
* Enhancement - Make UI smaller: [#2270](https://github.com/owncloud/owncloud-design-system/pull/2270)
* Enhancement - Oc-card style: [#2306](https://github.com/owncloud/owncloud-design-system/pull/2306)
* Enhancement - OcSelect dark mode improvements: [#2262](https://github.com/owncloud/owncloud-design-system/pull/2262)
* Enhancement - Progress bar indeterminate state: [#2200](https://github.com/owncloud/owncloud-design-system/pull/2200)
* Enhancement - Redesign notifications: [#2210](https://github.com/owncloud/owncloud-design-system/pull/2210)
* Enhancement - Use Inter font: [#2270](https://github.com/owncloud/owncloud-design-system/pull/2270)

https://github.com/owncloud/web/pull/7355
https://github.com/owncloud/owncloud-design-system/releases/tag/v14.0.0-alpha.12
https://github.com/owncloud/web/pull/7606
https://github.com/owncloud/owncloud-design-system/releases/tag/v14.0.0-alpha.17
6 changes: 6 additions & 0 deletions changelog/unreleased/enhancement-update-uppy
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
Enhancement: Update Uppy to v3.0.1

We've updated Uppy to v3.0.1. This allows us to enable the `creation-with-upload` extension, which saves up one request per file during upload.

https://github.com/owncloud/web/issues/7177
https://github.com/owncloud/web/pull/7515
6 changes: 6 additions & 0 deletions changelog/unreleased/enhancement-users-table-small-screens
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
Enhancement: Users table on small screen

We've improved the layout of the users table on small screens.

https://github.com/owncloud/web/pull/7476
https://github.com/owncloud/web/issues/7439
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
Enhancement: Adjust spacing of the files list options menu

We've adjusted the spacing of the files list options menu to visually match with the other menus.

https://github.com/owncloud/web/pull/7570
https://github.com/owncloud/web/issues/7541
2 changes: 2 additions & 0 deletions changelog/unreleased/enhancemnet-user-management-edit-quota
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,7 @@ Enhancement: User management app edit quota
We've added the possibility to change user's quota in the user management app.

https://github.com/owncloud/web/pull/7182
https://github.com/owncloud/web/pull/7530
https://github.com/owncloud/web/pull/7538
https://github.com/owncloud/web/issues/7059

10 changes: 9 additions & 1 deletion config/config.json.sample-ocis
Original file line number Diff line number Diff line change
Expand Up @@ -23,5 +23,13 @@
"id": "settings",
"path": "https://localhost:9200/settings.js"
}
]
],
"options" : {
"previewFileMimeTypes" : [
"image/gif",
"image/png",
"image/jpeg",
"text/plain"
]
}
}
8 changes: 7 additions & 1 deletion dev/docker/ocis.web.config.json
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,13 @@
"shares": {
"showAllOnLoad": true
}
}
},
"previewFileMimeTypes": [
"image/gif",
"image/png",
"image/jpeg",
"text/plain"
]
},
"apps": [
"files",
Expand Down
2 changes: 1 addition & 1 deletion dev/docker/selenium.Dockerfile
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# for m1 use SELENIUM_IMAGE=seleniarm/standalone-chromium:4.0.0-beta-1-20210215 docker-compose run selenium
#ARG SELENIUM_IMAGE=selenium/standalone-chrome-debug
#ARG SELENIUM_IMAGE=selenium/standalone-chrome
ARG SELENIUM_IMAGE
FROM ${SELENIUM_IMAGE}

Expand Down
3 changes: 2 additions & 1 deletion docker-compose.yml
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,7 @@ services:
- ./dist/js:/mnt/data/apps/web/js
- ./dist/themes:/mnt/data/apps/web/themes
- ./dist/icons:/mnt/data/apps/web/icons
- ./dist/fonts:/mnt/data/apps/web/fonts
- ./dist/index.html:/mnt/data/apps/web/index.html
- ./dist/manifest.json:/mnt/data/apps/web/manifest.json
- ./dist/oidc-callback.html:/mnt/data/apps/web/oidc-callback.html
Expand All @@ -93,7 +94,7 @@ services:
dockerfile: selenium.Dockerfile
context: ./dev/docker
args:
SELENIUM_IMAGE: ${SELENIUM_IMAGE:-selenium/standalone-chrome-debug}
SELENIUM_IMAGE: ${SELENIUM_IMAGE:-selenium/standalone-chrome:104.0-20220812}
container_name: web_selenium
ports:
- 4444:4444
Expand Down
2 changes: 1 addition & 1 deletion docs/getting-started.md
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ variables of the user object to come up with a user specific home path. This use
substring of a value of the authenticated user. Examples are `/Shares`, `/{{.Id}}` and `/{{substr 0 3 .Id}}/{{.Id}`.
- `options.disablePreviews` Set this option to `true` to disable previews in all the different file listing views. The only list view that is not affected
by this is the trash bin, as that doesn't allow showing previews at all.
- `options.previewFileExtensions` Specifies which filetypes will be previewed in the ui. For example to only preview jpg and txt files set this option to `["jpg", "txt"]`.
- `options.previewFileMimeTypes` Specifies which mimeTypes will be previewed in the ui. For example to only preview jpg and text files set this option to `["image/jpeg", "text/plain"]`.
- `options.disableFeedbackLink` Set this option to `true` to disable the feedback link in the topbar. Keeping it enabled (value `false` or absence of the option)
allows ownCloud to get feedback from your user base through a dedicated survey website.
- `options.feedbackLink` This accepts an object with the following optional fields to customize the feedback link in the topbar:
Expand Down
4 changes: 2 additions & 2 deletions docs/testing/acceptance-tests-all.md
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,8 @@ There are multiple ways to run Selenium:
### Setup using Docker

- Set the environment variables `SELENIUM_HOST` as `localhost` and `SERVER_HOST` in the format `http://<ip_addr>:9100`.
- If you are a Linux user, run `docker run --rm -d --network="host" -v /dev/shm:/dev/shm -v ${REMOTE_UPLOAD_DIR:-<middleware-root>/filesForUpload}:${LOCAL_UPLOAD_DIR:-/uploads}:ro --name web-tests-selenium selenium/standalone-chrome-debug`
- If you are a Mac user, run `docker run --rm -d -p ${SELENIUM_PORT:-4444}:4444 -p 5900:5900 -v /dev/shm:/dev/shm -v ${REMOTE_UPLOAD_DIR:-<middleware-root>/filesForUpload}:${LOCAL_UPLOAD_DIR:-/uploads}:ro --name web-tests-selenium selenium/standalone-chrome-debug`
- If you are a Linux user, run `docker run --rm -d --network="host" -v /dev/shm:/dev/shm -v ${REMOTE_UPLOAD_DIR:-<middleware-root>/filesForUpload}:${LOCAL_UPLOAD_DIR:-/uploads}:ro --name web-tests-selenium selenium/standalone-chrome`
- If you are a Mac user, run `docker run --rm -d -p ${SELENIUM_PORT:-4444}:4444 -p 5900:5900 -v /dev/shm:/dev/shm -v ${REMOTE_UPLOAD_DIR:-<middleware-root>/filesForUpload}:${LOCAL_UPLOAD_DIR:-/uploads}:ro --name web-tests-selenium selenium/standalone-chrome`
- This command creates a docker container which uses port forwarding instead of host networking [which is not supported on Mac](https://docs.docker.com/network/host/)

`<middleware-root>` needs to be replaced with the path where the middleware repository is cloned in your system.
Expand Down
2 changes: 1 addition & 1 deletion packages/web-app-external/src/components/ErrorScreen.vue
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<template>
<div class="oc-text-center">
<oc-icon size="xxlarge" name="error-warning" fill-type="line" />
<p v-if="message" class="oc-text-lead">{{ message }}</p>
<p v-if="message" class="oc-text-xlarge">{{ message }}</p>
</div>
</template>

Expand Down
Loading

0 comments on commit ef4e485

Please sign in to comment.