-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove root Makefile and get rid of cd in drone ci #852
Conversation
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks OK.
Note: The test-acceptance-api
make target and related code... is in ocis/Makefile
already. So this PR reduces duplication by removing the root Makefile
Will this change the way to run acceptance tests? And maybe other things? |
af4972d
to
5357f52
Compare
I added a hint to the referenced testing docs. There are tons of things to improve or even correct the docs, but I see this as out of scope for this PR. There is more progress going on like in #874 |
Yes, agree. Just make whatever changes are "obviously" needed because of this PR. |
85cdcff
to
425cf4c
Compare
425cf4c
to
0e1840a
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs |
No description provided.