Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove root Makefile and get rid of cd in drone ci #852

Merged
merged 4 commits into from
Nov 23, 2020

Conversation

wkloucek
Copy link
Contributor

No description provided.

@update-docs
Copy link

update-docs bot commented Nov 12, 2020

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

Copy link
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK.
Note: The test-acceptance-api make target and related code... is in ocis/Makefile already. So this PR reduces duplication by removing the root Makefile

@phil-davis
Copy link
Contributor

Will this change the way to run acceptance tests? And maybe other things?
For example, instructions in https://github.com/owncloud/ocis/blob/master/docs/ocis/development/testing.md will need updating in this PR.

@wkloucek
Copy link
Contributor Author

Will this change the way to run acceptance tests? And maybe other things?
For example, instructions in https://github.com/owncloud/ocis/blob/master/docs/ocis/development/testing.md will need updating in this PR.

I added a hint to the referenced testing docs.

There are tons of things to improve or even correct the docs, but I see this as out of scope for this PR. There is more progress going on like in #874

@phil-davis
Copy link
Contributor

There are tons of things to improve or even correct the docs, but I see this as out of scope for this PR

Yes, agree. Just make whatever changes are "obviously" needed because of this PR.

@wkloucek wkloucek marked this pull request as ready for review November 17, 2020 12:52
@sonarcloud
Copy link

sonarcloud bot commented Nov 23, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@wkloucek wkloucek merged commit b614ad1 into master Nov 23, 2020
@delete-merged-branch delete-merged-branch bot deleted the remove_root_makefile branch November 23, 2020 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants