Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests-only] extend API test coverage for content-disposition header #8378

Merged
merged 1 commit into from
Feb 7, 2024

Conversation

saw-jan
Copy link
Member

@saw-jan saw-jan commented Feb 6, 2024

Description

Added API test to check Content-Disposition header for a file containing comma in its name

Related Issue

Coverage for:

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:- [ ] Code changes

  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@saw-jan saw-jan added the QA:team label Feb 6, 2024
@saw-jan saw-jan self-assigned this Feb 6, 2024
@saw-jan saw-jan force-pushed the tests/coverage-Content-Disposition branch from f02a738 to fc5a8f9 Compare February 7, 2024 05:54
Copy link

sonarcloud bot commented Feb 7, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@saw-jan saw-jan marked this pull request as ready for review February 7, 2024 06:13
@phil-davis
Copy link
Contributor

@saw-jan we can merge this.
But it would also be nice to know what happens if the file name contains single or double quotes. Those will involve some sort of escaping in the Content-Disposition header, which could easily cause problems.
So some more scenario examples could be added in another PR.

@phil-davis phil-davis merged commit a2a9b10 into master Feb 7, 2024
2 checks passed
@delete-merged-branch delete-merged-branch bot deleted the tests/coverage-Content-Disposition branch February 7, 2024 07:57
ownclouders pushed a commit that referenced this pull request Feb 7, 2024
…tion

[tests-only] extend API test coverage for content-disposition header
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants