Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only][full-ci] refactoring user addition to group to graphapi #7360

Merged
merged 8 commits into from
Oct 17, 2023
Merged

[tests-only][full-ci] refactoring user addition to group to graphapi #7360

merged 8 commits into from
Oct 17, 2023

Conversation

S-Panta
Copy link
Contributor

@S-Panta S-Panta commented Sep 26, 2023 •
edited
Loading

Description

This PR refactors the user addition to group test code from ocs api to graphapi

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment:
  • locally
  • ci

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@S-Panta S-Panta self-assigned this Sep 27, 2023
@S-Panta S-Panta force-pushed the refactoring-user-addition-to-group-from-provisioningtograph branch from 83dbfa3 to 77995df Compare September 27, 2023 04:02
@S-Panta S-Panta changed the title [tests-only][full-ci] changed user addition to group to graphapi [tests-only][full-ci] refactoring user addition to group to graphapi Sep 27, 2023
@S-Panta S-Panta marked this pull request as ready for review September 27, 2023 04:03
This was referenced Sep 27, 2023
Merged
Closed
@S-Panta S-Panta force-pushed the refactoring-user-addition-to-group-from-provisioningtograph branch from 77995df to 323225c Compare October 3, 2023 09:54
saw-jan
saw-jan reviewed Oct 3, 2023
View reviewed changes
Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO, using nonexistent constantly should do the trick and we don't have to add extra param

tests/acceptance/features/bootstrap/GraphContext.php Outdated Show resolved Hide resolved
tests/acceptance/features/bootstrap/GraphContext.php Outdated Show resolved Hide resolved
@S-Panta S-Panta force-pushed the refactoring-user-addition-to-group-from-provisioningtograph branch 2 times, most recently from 655d446 to 5a4c035 Compare October 4, 2023 05:11
@S-Panta S-Panta force-pushed the refactoring-user-addition-to-group-from-provisioningtograph branch 4 times, most recently from 26d7907 to 711dba5 Compare October 9, 2023 11:04
@S-Panta S-Panta force-pushed the refactoring-user-addition-to-group-from-provisioningtograph branch from 767a6d1 to 3fff698 Compare October 12, 2023 05:01
@S-Panta S-Panta force-pushed the refactoring-user-addition-to-group-from-provisioningtograph branch 3 times, most recently from a92f5ff to f786a06 Compare October 12, 2023 09:21
@S-Panta S-Panta force-pushed the refactoring-user-addition-to-group-from-provisioningtograph branch from f786a06 to 67b47d4 Compare October 16, 2023 06:17
saw-jan
saw-jan approved these changes Oct 16, 2023
View reviewed changes
Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@saw-jan saw-jan requested a review from SagarGi October 16, 2023 06:26
SagarGi
SagarGi approved these changes Oct 16, 2023
View reviewed changes
Copy link
Member

@SagarGi SagarGi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just small change Other LGTM 👍

tests/acceptance/features/bootstrap/GraphContext.php Show resolved Hide resolved
@S-Panta S-Panta force-pushed the refactoring-user-addition-to-group-from-provisioningtograph branch from 67b47d4 to f3286e8 Compare October 17, 2023 04:06
@S-Panta S-Panta force-pushed the refactoring-user-addition-to-group-from-provisioningtograph branch from f3286e8 to f98197b Compare October 17, 2023 04:16
@sonarcloud
Copy link

sonarcloud bot commented Oct 17, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@saw-jan saw-jan merged commit dc3ed28 into master Oct 17, 2023
3 checks passed
@delete-merged-branch delete-merged-branch bot deleted the refactoring-user-addition-to-group-from-provisioningtograph branch October 17, 2023 05:49
ownclouders pushed a commit that referenced this pull request Oct 17, 2023
@S-Panta
[tests-only][full-ci] refactoring user addition to group to graphapi (#…
74e0fe0 
…7360)

* changed user addition to group to graphapi

* addressing the review

* addressing review regarding nonexistent user

* addressing the review

* updated expected failures file

* changing code to make it pass in reva edge

* addressing review

* addressing review
@S-Panta S-Panta mentioned this pull request Oct 20, 2023
Merged
S-Panta added a commit that referenced this pull request Oct 30, 2023
@S-Panta
[tests-only][full-ci] refactoring user addition to group to graphapi (#…
61b4e97 
…7360)

* changed user addition to group to graphapi

* addressing the review

* addressing review regarding nonexistent user

* addressing the review

* updated expected failures file

* changing code to make it pass in reva edge

* addressing review

* addressing review
saw-jan pushed a commit that referenced this pull request Oct 31, 2023
@S-Panta
[tests-only] [full-ci] backporting the PR related to user addition to…
e68b98d 
… group to graphapi (#7545)

* backporting the PR

* [tests-only][full-ci] refactoring user addition to group to graphapi (#7360)

* changed user addition to group to graphapi

* addressing the review

* addressing review regarding nonexistent user

* addressing the review

* updated expected failures file

* changing code to make it pass in reva edge

* addressing review

* addressing review
ownclouders pushed a commit that referenced this pull request Oct 31, 2023
@S-Panta
[tests-only] [full-ci] backporting the PR related to user addition to…
f8b8a93 
… group to graphapi (#7545)

* backporting the PR

* [tests-only][full-ci] refactoring user addition to group to graphapi (#7360)

* changed user addition to group to graphapi

* addressing the review

* addressing review regarding nonexistent user

* addressing the review

* updated expected failures file

* changing code to make it pass in reva edge

* addressing review

* addressing review
ownclouders pushed a commit that referenced this pull request Nov 1, 2023
@S-Panta
[tests-only] [full-ci] backporting the PR related to user addition to…
8af7678 
… group to graphapi (#7545)

* backporting the PR

* [tests-only][full-ci] refactoring user addition to group to graphapi (#7360)

* changed user addition to group to graphapi

* addressing the review

* addressing review regarding nonexistent user

* addressing the review

* updated expected failures file

* changing code to make it pass in reva edge

* addressing review

* addressing review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saw-jan saw-jan saw-jan approved these changes

@SagarGi SagarGi SagarGi approved these changes

@PrajwolAmatya PrajwolAmatya Awaiting requested review from PrajwolAmatya

@amrita-shrestha amrita-shrestha Awaiting requested review from amrita-shrestha

@grgprarup grgprarup Awaiting requested review from grgprarup

@SwikritiT SwikritiT Awaiting requested review from SwikritiT

Assignees

@S-Panta S-Panta

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@S-Panta @SwikritiT @SagarGi @saw-jan