Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[full-ci] prepare release, bump version #5156

Merged
merged 1 commit into from
Nov 30, 2022
Merged

[full-ci] prepare release, bump version #5156

merged 1 commit into from
Nov 30, 2022

Conversation

micbar
Copy link
Contributor

@micbar micbar commented Nov 29, 2022 •
edited
Loading

Description

  • Run Full CI
  • Tag
  • Merge back to master
  • Create branch stable-2.0

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@update-docs
Copy link

update-docs bot commented Nov 29, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@micbar micbar self-assigned this Nov 29, 2022
phil-davis
phil-davis approved these changes Nov 29, 2022
View reviewed changes
Copy link
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I just made a small suggestion for the mount-ids.

changelog/2.0.0_2022-11-30/mount-ids.md Outdated Show resolved Hide resolved
kulmann
kulmann approved these changes Nov 29, 2022
View reviewed changes
Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some changelog nitpicks (see comments). Also, I've messed up the web changelog items a bit:

  • update-web-6.0.0-rc.6.md,
  • update-web-6.0.0-rc.8.md and
  • update-web-6.0.0.md

contain all changes instead of the diff from one to the other. But I'd rather delete the two rc-version changelog files completely than switching to diffs, because I find the breaking change warnings rather important. What do you think? Delete update-web-6.0.0-rc.6.md and update-web-6.0.0-rc.8.md? Or keep it like it is?

The rest of the PR looks fine. Changelog folder name, changelog template (finally getting rid of the manually updated suffixes) and the version bumps all look good.

changelog/2.0.0_2022-11-30/mount-ids.md Outdated Show resolved Hide resolved
changelog/2.0.0_2022-11-30/mount-ids.md Outdated Show resolved Hide resolved
@micbar
Copy link
Contributor Author

micbar commented Nov 29, 2022

Some changelog nitpicks (see comments). Also, I've messed up the web changelog items a bit:

  • update-web-6.0.0-rc.6.md,
  • update-web-6.0.0-rc.8.md and
  • update-web-6.0.0.md

contain all changes instead of the diff from one to the other. But I'd rather delete the two rc-version changelog files completely than switching to diffs, because I find the breaking change warnings rather important. What do you think? Delete update-web-6.0.0-rc.6.md and update-web-6.0.0-rc.8.md? Or keep it like it is?

The rest of the PR looks fine. Changelog folder name, changelog template (finally getting rid of the manually updated suffixes) and the version bumps all look good.

I will delete the two rc versions like you proposed.

@sonarcloud
Copy link

sonarcloud bot commented Nov 29, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@micbar micbar marked this pull request as draft November 29, 2022 22:55
@micbar
Copy link
Contributor Author

micbar commented Nov 29, 2022

waiting for the final go / no go decision.

@micbar micbar marked this pull request as ready for review November 30, 2022 07:42
@micbar micbar merged commit 86f51ef into master Nov 30, 2022
@delete-merged-branch delete-merged-branch bot deleted the release-2.0.0 branch November 30, 2022 07:42
ownclouders pushed a commit that referenced this pull request Nov 30, 2022
@micbar
commit 86f51ef
a02b9d4 
Merge: 8c76757 ab57daf
Author: Michael Barz <mbarz@owncloud.com>
Date:   Wed Nov 30 08:42:41 2022 +0100

    Merge pull request #5156 from owncloud/release-2.0.0

    [full-ci] prepare release, bump version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kulmann kulmann kulmann approved these changes

@phil-davis phil-davis phil-davis approved these changes

@butonic butonic Awaiting requested review from butonic

Assignees

@micbar micbar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@micbar @phil-davis @kulmann