Filter hidden files #5018
Merged
Filter hidden files #5018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💥 Acceptance test Core-API-Tests-ocis-storage-1 failed. Further test are cancelled... |
|
Just a question, should this be set by default or maybe defined via a env var? Because you do not restrict searching but filtering the results? |
|
@mmattel the e2e test suite also wasn't happy about filtering hidden files by default. We'll now index the hidden state so it's available for future changes but we don't filter by default. So the search behaves exactly the same as before. |
aduffeck
force-pushed
the
filter-hidden-files
branch
from
ad06174
to
9a6d3e4
Compare
butonic
approved these changes
Nov 10, 2022
butonic
requested changes
Nov 10, 2022
aduffeck
force-pushed
the
filter-hidden-files
branch
from
c75ba7a
to
a9617c5
Compare
aduffeck
force-pushed
the
filter-hidden-files
branch
from
a9617c5
to
a2afd75
Compare
|
Kudos, SonarCloud Quality Gate passed! |
butonic
approved these changes
Nov 10, 2022
ownclouders
pushed a commit
that referenced
this pull request
Nov 10, 2022
Author: Andre Duffeck <aduffeck@users.noreply.github.com>
Date: Thu Nov 10 17:05:43 2022 +0100
Filter hidden files (#5018)
* Filter hidden files from search results
* Add changelog
* Do not filter hidden files by default
* Set the hidden fields when converting fields to an entity
* Fix test
73 tasks
49 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR hidden files (dotfiles) will no longer be part of the search results.