Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate Space Names #4955

Merged
merged 2 commits into from
Nov 3, 2022
Merged

Validate Space Names #4955

merged 2 commits into from
Nov 3, 2022

Conversation

kobergj
Copy link
Collaborator

@kobergj kobergj commented Nov 2, 2022

We now return BAD REQUEST when space names are

  • too long (max 255 characters)
  • containing evil characters (/, \, ., \\, :, ?, *, ", >, <, |)

Additionally leading and trailing spaces will be removed silently.

fixes this: #4925

@ownclouders
Copy link
Contributor

ownclouders commented Nov 2, 2022

💥 Acceptance test settingsUITests failed. Further test are cancelled...

@ownclouders
Copy link
Contributor

💥 Acceptance test Core-API-Tests-ocis-storage-8 failed. Further test are cancelled...

Signed-off-by: jkoberg <jkoberg@owncloud.com>
Copy link
Contributor

@micbar micbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Co-authored-by: Michael Barz <michael.barz@zeitgestalten.eu>
@sonarcloud
Copy link

sonarcloud bot commented Nov 3, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

44.4% 44.4% Coverage
0.0% 0.0% Duplication

@butonic
Copy link
Member

butonic commented Nov 3, 2022

https://drone.owncloud.com/owncloud/ocis/16604 is green, force merging

@butonic butonic merged commit a5bccc2 into owncloud:master Nov 3, 2022
ownclouders pushed a commit that referenced this pull request Nov 3, 2022
Author: kobergj <jkoberg@owncloud.com>
Date:   Thu Nov 3 11:39:02 2022 +0100

    Validate Space Names (#4955)

    * validate space names

    Signed-off-by: jkoberg <jkoberg@owncloud.com>

    * Update services/graph/pkg/service/v0/drives.go

    Co-authored-by: Michael Barz <michael.barz@zeitgestalten.eu>

    Signed-off-by: jkoberg <jkoberg@owncloud.com>
    Co-authored-by: Michael Barz <michael.barz@zeitgestalten.eu>
@micbar micbar mentioned this pull request Nov 25, 2022
73 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants