[full-ci] Build idp and settings frontends with pnpm #4892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dschmidt
changed the title
dschmidt
changed the title
dschmidt
requested review from
wkloucek,
micbar,
phil-davis,
individual-it,
kulmann and
lookacat
as code owners
|
Kudos, SonarCloud Quality Gate passed! |
wkloucek
reviewed
Oct 25, 2022
| @@ -1089,7 +1089,8 @@ def settingsUITests(ctx, storage = "ocis", accounts_hash_difficulty = 4): | |||
| # TODO: settings/package.json has all the acceptance test dependencies | |||
| # they shouldn't be needed since we could also use them from web:/tests/acceptance/package.json | |||
| "cd %s/services/settings" % dirs["base"], | |||
| "retry -t 3 'yarn install --immutable'", | |||
| "pnpm config set store-dir ./.pnpm-store", | |||
There was a problem hiding this comment.
Does pnpm by default use the lock file?
There was a problem hiding this comment.
There was a problem hiding this comment.
kulmann
approved these changes
Oct 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use pnpm for the services built in this repo.
Related Issue
Motivation and Context
We recently switched to pnpm in oC Web (see the PR here: owncloud/web#7835)
It provides isolation between subpackages and overall avoids a whole class of careless mistakes.
I would recommend to switch the service frontends in oCIS as well, but it's not strictly neccessary for the Web team. The important changes for us are in #4878
It's a slight disruption to backend developers as you need to enable pnpm, if you don't have it already.
See https://pnpm.io/installation for reference.
Easiest is probably
npm install -g pnpmif you already havenpm.As I prepared the changes already (and we decided to split it out of the original PR), I'm offering them here to you.
It really depends on the oCIS team if you want to accept this change or not. No hard feelings if you prefer to stick with yarn. Up to you :)
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: