use eos driver for /eos namespace #484

butonic · 2020-08-24T13:36:20Z

when accessing /eos we need to use the eos driver that does not apply the home layout. The first path segment is provided by clients accessing the /dav/files/<userid> endpoint. This PR will make the current configuration work with the existing code in reva for the eos driver as well as the ocdav implementation for the /dav/files endpoint.

submit PR to reva that applies the user layout in ocdav when accessing via /dav/files so we can route to any users files. access permissions are checked in the storage provider but the dav endpoint is needed to access other users storage. was already possible, but i forgot it. and it is not needed for the setup.

The /Shared folder only makes sense for the /home namespace. when accessing /eos it is not part of the tree.

update-docs · 2020-08-24T13:36:23Z

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

docs/eos.md

PVince81 · 2020-08-25T09:37:18Z

with the env var change proposed in the comment, creating shares do work

however listing shares still has a 500 error with panic, due to:

ocis          | 2020-08-25T09:35:01Z ERR eos: resource is outside the directory of the logged-in user: internal=/eos/dockertest/reva/users/einstein/sha2 trim=/eos/dockertest/reva/users/marie namespace=/eos/dockertest/reva/users pkg=rgrpc service=reva traceid=87be475afa5bc67d51a2403ad87bee8a
ocis          | 2020-08-25T09:35:01Z ERR unary code=Internal end="25/Aug/2020:09:35:01 +0000" from=tcp://127.0.0.1:53804 pkg=rgrpc service=reva start="25/Aug/2020:09:35:01 +0000" time_ns=39223765 traceid=87be475afa5bc67d51a2403ad87bee8a uri=/cs3.storage.provider.v1beta1.ProviderAPI/Stat user-agent=grpc-go/1.26.0

strange that now we see "marie" instead of her uuid...

PVince81 · 2020-08-25T09:37:52Z

ah, maybe instead of replacing I need both... adjusting...

PVince81 · 2020-08-25T09:43:15Z

according to our discussion, the EOS layout must be an empty string.
I suspect this cannot work because an empty string for a config would result in a default value.
I'm now trying this trick: REVA_STORAGE_EOS_LAYOUT='{{""}}'

PVince81 · 2020-08-25T09:51:05Z

seems with a truly empty storage layout for EOS, it breaks:

PVince81 · 2020-08-26T21:09:45Z

docker-compose.yml

      REVA_FRONTEND_URL: https://${OCIS_DOMAIN:-localhost}:9200
      REVA_DATAGATEWAY_URL: https://${OCIS_DOMAIN:-localhost}:9200/data
-
+      # TODO dav/files namespace is broken because it should use /home not /oc or /eos


I've moved all those to owncloud/product#129 (comment), please remove these lines

PVince81 · 2020-08-26T21:10:38Z

so we managed to have something working with the setup from this PR, see owncloud/product#129 (comment)

next up:

get rid of todo entries
split names.md to a separate ticket/pr
get this merged!

PVince81 · 2020-08-27T09:09:08Z

@butonic please undraft and squash

butonic · 2020-08-27T09:11:03Z

raised #499 for the namespaces docs

Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de> make home provider return eos storageid Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de> add hint about REVA_STORAGE_HOME_MOUNT_ID Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de> use ishanks shetup Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de> hmm Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de> working setup Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de> use correct env vars for data provider Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de> remove names.md Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de> cleanup env vars Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>

PVince81

I've retested sharing on ocis master with this config and it still works 👍

Merge: fe73c6a 3dc3241 Author: Vincent Petry <pvince81@owncloud.com> Date: Thu Aug 27 11:59:23 2020 +0200 Merge pull request #484 from butonic/use-eos-driver use eos driver for /eos namespace

butonic · 2020-08-27T12:34:50Z

docker-compose.yml

      OCIS_DOMAIN: ${OCIS_DOMAIN:-localhost}
+      PROXY_OIDC_ISSUER: https://${OCIS_DOMAIN:-localhost}:9200


originally added by @jnweiger in #468

butonic · 2020-08-27T12:35:05Z

docker-compose.yml

      PHOENIX_OIDC_AUTHORITY: https://${OCIS_DOMAIN:-localhost}:9200
      PHOENIX_OIDC_METADATA_URL: https://${OCIS_DOMAIN:-localhost}:9200/.well-known/openid-configuration
      PHOENIX_WEB_CONFIG_SERVER: https://${OCIS_DOMAIN:-localhost}:9200
-      PROXY_HTTP_ADDR: 0.0.0.0:9200


this is the dafault

butonic · 2020-08-27T12:35:37Z

docker-compose.yml

      KONNECTD_ISS: https://${OCIS_DOMAIN:-localhost}:9200
-      KONNECTD_LOG_LEVEL: debug


log level will be taken from OCIS_LOG_LEVEL. if not that is a bug and should be fixed properly

butonic · 2020-08-27T12:36:18Z

docker-compose.yml

      KONNECTD_ISS: https://${OCIS_DOMAIN:-localhost}:9200
-      KONNECTD_LOG_LEVEL: debug
-      KONNECTD_TLS: '0'


the default is already falseas is necessary because TLS handling is offloaded to the proxy

I'd be a fan of leaving all the defaults. Or document the defaults as a comment.

butonic mentioned this pull request Aug 24, 2020

listing shares on eos has empty filename owncloud/ocis-reva#451

Closed

butonic marked this pull request as draft August 24, 2020 14:56

butonic self-assigned this Aug 24, 2020

butonic added the documentation label Aug 24, 2020

PVince81 reviewed Aug 25, 2020

View reviewed changes

docs/eos.md Outdated Show resolved Hide resolved

PVince81 reviewed Aug 25, 2020

View reviewed changes

docs/eos.md Outdated Show resolved Hide resolved

PVince81 mentioned this pull request Aug 25, 2020

[EOS] Sharing does not work owncloud/product#129

Closed

butonic force-pushed the use-eos-driver branch from 9d84d3e to a81b660 Compare August 25, 2020 15:02

PVince81 mentioned this pull request Aug 25, 2020

Rewire dav files endpoint to home cs3org/reva#1120

Closed

13 tasks

PVince81 reviewed Aug 26, 2020

View reviewed changes

butonic mentioned this pull request Aug 27, 2020

fix docker-compose.yml for beta9 #468

Closed

butonic force-pushed the use-eos-driver branch from 826f02a to b9d6e0b Compare August 27, 2020 07:54

PVince81 marked this pull request as ready for review August 27, 2020 09:10

butonic force-pushed the use-eos-driver branch from b9d6e0b to 3dc3241 Compare August 27, 2020 09:13

PVince81 mentioned this pull request Aug 27, 2020

initial namespaces.md #499

Closed

PVince81 approved these changes Aug 27, 2020

View reviewed changes

PVince81 merged commit 5d3eb1d into owncloud:master Aug 27, 2020

PVince81 mentioned this pull request Aug 27, 2020

[OCIS] run acceptance tests with EOS owncloud/product#156

Closed

2 tasks

ownclouders pushed a commit that referenced this pull request Aug 27, 2020

commit 5d3eb1d

1fe9835

Merge: fe73c6a 3dc3241 Author: Vincent Petry <pvince81@owncloud.com> Date: Thu Aug 27 11:59:23 2020 +0200 Merge pull request #484 from butonic/use-eos-driver use eos driver for /eos namespace

butonic deleted the use-eos-driver branch August 27, 2020 11:08

butonic commented Aug 27, 2020

View reviewed changes

butonic mentioned this pull request Aug 27, 2020

[QA] Login to beta9 fails runtime error: invalid memory #463

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

use eos driver for /eos namespace #484

use eos driver for /eos namespace #484

butonic commented Aug 24, 2020 •

edited

Loading

update-docs bot commented Aug 24, 2020

PVince81 commented Aug 25, 2020

PVince81 commented Aug 25, 2020

PVince81 commented Aug 25, 2020 •

edited

Loading

PVince81 commented Aug 25, 2020

PVince81 Aug 26, 2020

PVince81 commented Aug 26, 2020 •

edited

Loading

PVince81 commented Aug 27, 2020

butonic commented Aug 27, 2020

PVince81 left a comment

butonic Aug 27, 2020

butonic Aug 27, 2020

butonic Aug 27, 2020

butonic Aug 27, 2020

jnweiger Sep 1, 2020

		OCIS_DOMAIN: ${OCIS_DOMAIN:-localhost}
		PROXY_OIDC_ISSUER: https://${OCIS_DOMAIN:-localhost}:9200

		KONNECTD_ISS: https://${OCIS_DOMAIN:-localhost}:9200
		KONNECTD_LOG_LEVEL: debug

use eos driver for /eos namespace #484

use eos driver for /eos namespace #484

Conversation

butonic commented Aug 24, 2020 • edited Loading

update-docs bot commented Aug 24, 2020

PVince81 commented Aug 25, 2020

PVince81 commented Aug 25, 2020

PVince81 commented Aug 25, 2020 • edited Loading

PVince81 commented Aug 25, 2020

PVince81 Aug 26, 2020

Choose a reason for hiding this comment

PVince81 commented Aug 26, 2020 • edited Loading

PVince81 commented Aug 27, 2020

butonic commented Aug 27, 2020

PVince81 left a comment

Choose a reason for hiding this comment

butonic Aug 27, 2020

Choose a reason for hiding this comment

butonic Aug 27, 2020

Choose a reason for hiding this comment

butonic Aug 27, 2020

Choose a reason for hiding this comment

butonic Aug 27, 2020

Choose a reason for hiding this comment

jnweiger Sep 1, 2020

Choose a reason for hiding this comment

butonic commented Aug 24, 2020 •

edited

Loading

PVince81 commented Aug 25, 2020 •

edited

Loading

PVince81 commented Aug 26, 2020 •

edited

Loading