Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow to configure applications for web #4578

Merged
merged 1 commit into from
Sep 14, 2022
Merged

allow to configure applications for web #4578

merged 1 commit into from
Sep 14, 2022

Conversation

wkloucek
Copy link
Contributor

Description

allows to configure applications for web.

Related Issue

Motivation and Context

Modify the app switcher in web

How Has This Been Tested?

  • web.yaml: 
    web:
  config:
    applications:
      -  icon: swap-box
         url: https://owncloud.com
         target: _self
         title:
           de: ownCloud Webseite
           en: ownCloud Webpage

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@update-docs
Copy link

update-docs bot commented Sep 14, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@wkloucek wkloucek force-pushed the web-configuration-applications branch from 8623cd3 to 78c2173 Compare September 14, 2022 08:08
@wkloucek wkloucek force-pushed the web-configuration-applications branch from 78c2173 to 1caffa3 Compare September 14, 2022 08:09
@wkloucek wkloucek marked this pull request as ready for review September 14, 2022 08:10
@sonarcloud
Copy link

sonarcloud bot commented Sep 14, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@C0rby C0rby merged commit b71eeb9 into master Sep 14, 2022
@delete-merged-branch delete-merged-branch bot deleted the web-configuration-applications branch September 14, 2022 09:32
ownclouders pushed a commit that referenced this pull request Sep 14, 2022
commit b71eeb9
b11069c 
Merge: b1d3ba2 1caffa3
Author: David Christofas <dchristofas@owncloud.com>
Date:   Wed Sep 14 11:32:14 2022 +0200

    Merge pull request #4578 from owncloud/web-configuration-applications

    allow to configure applications for web
@wkloucek wkloucek mentioned this pull request Nov 9, 2022
Merged
5 tasks
@micbar micbar mentioned this pull request Nov 25, 2022
Closed
73 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@C0rby C0rby C0rby approved these changes

@kulmann kulmann Awaiting requested review from kulmann kulmann is a code owner

@kobergj kobergj Awaiting requested review from kobergj

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wkloucek @C0rby