Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[full-ci] add open-with-web endpoint #4376

Merged
merged 7 commits into from
Aug 18, 2022
Merged

[full-ci] add open-with-web endpoint #4376

merged 7 commits into from
Aug 18, 2022

Conversation

wkloucek
Copy link
Contributor

@wkloucek wkloucek commented Aug 10, 2022 •
edited
Loading

Description

We've added an /app/open-with-web endpoint to the app provider, so that
clients that are no browser or have only limited browser access can also open apps with the help of a Web URL.

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@update-docs
Copy link

update-docs bot commented Aug 10, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@ownclouders
Copy link
Contributor

💥 Acceptance test Core-API-Tests-ocis-storage-2 failed. Further test are cancelled...

kulmann
kulmann reviewed Aug 11, 2022
View reviewed changes
services/frontend/pkg/revaconfig/config.go Outdated
"app": "appname",
},
"staticurlparams": map[string]string{
"contextRouteName": "files-spaces-personal",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can drop the contextRouteName from the params when owncloud/web#7437 is merged, released and embedded into ocis.

@wkloucek wkloucek changed the title add open-with-web endpoint, needs cs3org/reva#3143 add open-with-web endpoint Aug 12, 2022
@wkloucek wkloucek mentioned this pull request Aug 12, 2022
Merged
@wkloucek wkloucek marked this pull request as ready for review August 12, 2022 14:07
@wkloucek wkloucek mentioned this pull request Aug 12, 2022
Closed
@wkloucek wkloucek changed the title add open-with-web endpoint [full-ci] add open-with-web endpoint Aug 17, 2022
C0rby
C0rby reviewed Aug 17, 2022
View reviewed changes
services/frontend/pkg/revaconfig/config.go Outdated Show resolved Hide resolved
services/frontend/pkg/revaconfig/config.go Outdated Show resolved Hide resolved
@wkloucek wkloucek requested a review from C0rby August 17, 2022 10:27
@wkloucek wkloucek mentioned this pull request Aug 17, 2022
Merged
9 tasks
@wkloucek wkloucek requested a review from kulmann August 18, 2022 05:20
kulmann
kulmann approved these changes Aug 18, 2022
View reviewed changes
services/frontend/pkg/revaconfig/config.go Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Aug 18, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@wkloucek wkloucek merged commit ef8c600 into owncloud:master Aug 18, 2022
@wkloucek wkloucek deleted the open-with-web-endpoitn branch August 18, 2022 08:21
ownclouders pushed a commit that referenced this pull request Aug 18, 2022
@wkloucek
commit ef8c600
4b699a6 
Merge: cf12ecf 70bce6b
Author: Willy Kloucek <34452982+wkloucek@users.noreply.github.com>
Date:   Thu Aug 18 10:21:01 2022 +0200

    Merge pull request #4376 from wkloucek/open-with-web-endpoitn

    [full-ci] add open-with-web endpoint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kulmann kulmann kulmann approved these changes

@kobergj kobergj Awaiting requested review from kobergj

@dragonchaser dragonchaser Awaiting requested review from dragonchaser

@C0rby C0rby Awaiting requested review from C0rby

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wkloucek @ownclouders @kulmann @C0rby