Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests-only] [full-ci] Remove tests related to issue-1328,1310,2249 from expected to fail #4220

Merged
merged 1 commit into from
Jul 19, 2022

Conversation

SwikritiT
Copy link
Contributor

@SwikritiT SwikritiT commented Jul 18, 2022

Description

Related Issue

Motivation and Context

How Has This Been Tested?

  • CI

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@ownclouders
Copy link
Contributor

💥 Acceptance test Core-API-Tests-ocis-storage-5 failed. Further test are cancelled...

@SwikritiT SwikritiT changed the title [tests-only] Remove tests related to from expected to fail [tests-only] [full-ci] Remove tests related to from expected to fail Jul 19, 2022
@SwikritiT SwikritiT force-pushed the remove-tests-related-to-issue-1328 branch from fab9dab to 116c1bc Compare July 19, 2022 04:02
@phil-davis
Copy link
Contributor

PR title is "Remove tests related to from expected to fail" - related to what?
Please update the PR title.

@SwikritiT SwikritiT changed the title [tests-only] [full-ci] Remove tests related to from expected to fail [tests-only] [full-ci] Remove tests related to from expected to fail retaled to issue-1328 Jul 19, 2022
@SwikritiT SwikritiT changed the title [tests-only] [full-ci] Remove tests related to from expected to fail retaled to issue-1328 [tests-only] [full-ci] Remove tests related to issue-1328 from expected to fail Jul 19, 2022
@SwikritiT
Copy link
Contributor Author

PR title is "Remove tests related to from expected to fail" - related to what? Please update the PR title.

Done. Thanks for pointing it out!

Comment on lines -55 to -58
### [Versions Cleanup not available](https://github.com/owncloud/ocis/issues/1310)
- [webUIFilesActionMenu/versions.feature:37](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUIFilesActionMenu/versions.feature#L37)
- [webUIFilesActionMenu/versions.feature:48](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUIFilesActionMenu/versions.feature#L48)
- [webUIFilesActionMenu/versions.feature:63](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUIFilesActionMenu/versions.feature#L63)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These tests were skipped by PR owncloud/web#7282

@@ -31,9 +31,6 @@ Other free text and markdown formatting can be used elsewhere in the document if
- [webUIFavorites/unfavoriteFile.feature:102](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUIFavorites/unfavoriteFile.feature#L102)
- [webUIResharing1/reshareUsers.feature:194](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUIResharing1/reshareUsers.feature#L194)

### [file_path property is not unique for a share created with same resource name i.e already present in sharee](https://github.com/owncloud/ocis/issues/2249)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test was skipped by PR owncloud/web#7281

@SwikritiT SwikritiT changed the title [tests-only] [full-ci] Remove tests related to issue-1328 from expected to fail [tests-only] [full-ci] Remove tests related to issue-1328,1310,1328 from expected to fail Jul 19, 2022
@SwikritiT SwikritiT changed the title [tests-only] [full-ci] Remove tests related to issue-1328,1310,1328 from expected to fail [tests-only] [full-ci] Remove tests related to issue-1328,1310,2249 from expected to fail Jul 19, 2022
@phil-davis phil-davis force-pushed the remove-tests-related-to-issue-1328 branch from 007fbc4 to c774fb1 Compare July 19, 2022 13:23
Many test scenarios are removed from expected-failures because they
are scenarios that are not relevant to oCIS and have been tagged and
skipped on oCIS in core PRs today.
@phil-davis phil-davis force-pushed the remove-tests-related-to-issue-1328 branch from c774fb1 to 39234fb Compare July 19, 2022 13:58
@phil-davis phil-davis marked this pull request as ready for review July 19, 2022 14:01
@sonarcloud
Copy link

sonarcloud bot commented Jul 19, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@phil-davis phil-davis merged commit 6fd4f1b into master Jul 19, 2022
@delete-merged-branch delete-merged-branch bot deleted the remove-tests-related-to-issue-1328 branch July 19, 2022 14:34
ownclouders pushed a commit that referenced this pull request Jul 19, 2022
Merge: 295d20c 39234fb
Author: Phil Davis <phil@jankaritech.com>
Date:   Tue Jul 19 20:19:49 2022 +0545

    Merge pull request #4220 from owncloud/remove-tests-related-to-issue-1328

    [tests-only] [full-ci] Remove tests related to issue-1328,1310,2249 from expected to fail
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants