Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update bingo #3573

Merged
merged 1 commit into from
Apr 25, 2022
Merged

update bingo #3573

merged 1 commit into from
Apr 25, 2022

Conversation

wkloucek
Copy link
Contributor

Description

updates bingo to fix building issues on MacOS with Go 1.18 (bwplotka/bingo#109)

Related Issue

  • Fixes <issue_link>

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@update-docs
Copy link

update-docs bot commented Apr 25, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@sonarcloud
Copy link

sonarcloud bot commented Apr 25, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

fschade
fschade approved these changes Apr 25, 2022
View reviewed changes
Copy link
Contributor

@fschade fschade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

testet with go version go1.18.1 darwin/arm64.
Works :) 🚀

Thanks

@fschade fschade merged commit 634d557 into owncloud:master Apr 25, 2022
ownclouders pushed a commit that referenced this pull request Apr 25, 2022
@wkloucek
commit 634d557
19c60d6 
Author: Willy Kloucek <34452982+wkloucek@users.noreply.github.com>
Date:   Mon Apr 25 13:42:32 2022 +0200

    update bingo (#3573)
@wkloucek wkloucek deleted the update-bingo branch May 20, 2022 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@butonic butonic butonic approved these changes

@fschade fschade fschade approved these changes

@C0rby C0rby Awaiting requested review from C0rby

@kobergj kobergj Awaiting requested review from kobergj

@pascalwengerter pascalwengerter Awaiting requested review from pascalwengerter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wkloucek @butonic @fschade