Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update reva to include decomposedfs nodes-per-space #3228

Merged
merged 8 commits into from
Mar 2, 2022
Merged

Conversation

butonic
Copy link
Member

@butonic butonic commented Feb 23, 2022

Run ocis ci for cs3org/reva#2554

  • add new role to allow accounts service to create-space for metadata storage
  • add create-space w/ constraint OWN to normal user role

@update-docs
Copy link

update-docs bot commented Feb 23, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@ownclouders
Copy link
Contributor

ownclouders commented Feb 23, 2022

💥 Acceptance test settingsUITests failed. Further test are cancelled...

@butonic butonic changed the title update reva to unclude decomposedfs nodes-per-space update reva to include decomposedfs nodes-per-space Feb 24, 2022
@butonic butonic force-pushed the nodes-per-space branch 2 times, most recently from 9aa711a to 0bc28dd Compare February 25, 2022 08:17
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@micbar micbar mentioned this pull request Feb 28, 2022
26 tasks
butonic and others added 3 commits March 1, 2022 08:53
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
Copy link
Contributor

@fschade fschade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just some minor and optional findings.

graph/pkg/service/v0/drives.go Show resolved Hide resolved
graph/pkg/service/v0/drives.go Show resolved Hide resolved
settings/pkg/service/v0/settings.go Show resolved Hide resolved
settings/pkg/service/v0/settings.go Show resolved Hide resolved
@micbar
Copy link
Contributor

micbar commented Mar 1, 2022

@fschade the failing webUI smoke test smells not good. Something to do with the latest reva change cs3org/reva#2596 ?

@sonarcloud
Copy link

sonarcloud bot commented Mar 1, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

1.8% 1.8% Coverage
0.0% 0.0% Duplication

@micbar micbar merged commit beaac40 into master Mar 2, 2022
@delete-merged-branch delete-merged-branch bot deleted the nodes-per-space branch March 2, 2022 07:47
ownclouders pushed a commit that referenced this pull request Mar 2, 2022
Author: Jörn Friedrich Dreyer <jfd@owncloud.com>
Date:   Wed Mar 2 08:47:53 2022 +0100

    update reva to include decomposedfs nodes-per-space (#3228)

    * update reva to include decomposedfs nodes-per-space

    Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>

    * check create space with own constraint

    Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>

    * update reva

    Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>

    * unexpected passed

    Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>

    * update reva

    Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>

    * remove unused variable

    Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>

    * revert reva commit id

    Co-authored-by: Florian Schade <f.schade@icloud.com>
labkode pushed a commit to cernbox/ocis that referenced this pull request Mar 3, 2022
* update reva to include decomposedfs nodes-per-space

Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>

* check create space with own constraint

Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>

* update reva

Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>

* unexpected passed

Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>

* update reva

Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>

* remove unused variable

Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>

* revert reva commit id

Co-authored-by: Florian Schade <f.schade@icloud.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants