Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make events settings configurable #3214

Merged
merged 1 commit into from
Feb 22, 2022
Merged

make events settings configurable #3214

merged 1 commit into from
Feb 22, 2022

Conversation

wkloucek
Copy link
Contributor

Description

make events settings configurable

Related Issue

  • Fixes individual service deployments and kubernetes deployments

Motivation and Context

How Has This Been Tested?

  • locally

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@kobergj kobergj mentioned this pull request Feb 22, 2022
Merged
9 tasks
kobergj
kobergj approved these changes Feb 22, 2022
View reviewed changes
storage/pkg/config/defaultconfig.go Outdated
@@ -348,6 +348,10 @@ func DefaultConfig() *Config {
PublicEnableExpiredSharesCleanup: true,
PublicJanitorRunInterval: 60,
UserStorageMountID: "",
Events: Events{
Address: "127.0.0.1:4222",
Copy link
Collaborator

@kobergj kobergj Feb 22, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, this breaks because of my PR #3210

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pointing out, could you please check again?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh already approved 👍

@ownclouders
Copy link
Contributor

💥 Acceptance test Core-API-Tests-ocis-storage-6 failed. Further test are cancelled...

@sonarcloud
Copy link

sonarcloud bot commented Feb 22, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@wkloucek wkloucek merged commit 7e39147 into master Feb 22, 2022
@delete-merged-branch delete-merged-branch bot deleted the events-config branch February 22, 2022 14:40
ownclouders pushed a commit that referenced this pull request Feb 22, 2022
@wkloucek
commit 7e39147
3f00f2a 
Merge: 949308b 6cbdbd8
Author: Willy Kloucek <34452982+wkloucek@users.noreply.github.com>
Date:   Tue Feb 22 15:40:43 2022 +0100

    Merge pull request #3214 from owncloud/events-config

    make events settings configurable
@micbar micbar mentioned this pull request Mar 3, 2022
Closed
26 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kobergj kobergj kobergj approved these changes

@butonic butonic Awaiting requested review from butonic

@micbar micbar Awaiting requested review from micbar

@C0rby C0rby Awaiting requested review from C0rby

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wkloucek @ownclouders @kobergj