fix: align storage metadata GPRC bind port with other variable names #3169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
|
This build has transient download issues in the docker image, can someone please re-run this? |
|
💥 Acceptance test Web-Tests-ocis-smoke-ocis-storage-2 failed. Further test are cancelled... |
Currently STORAGE_METADATA_GRPC_PROVIDER_ADDR environment variable used as the way to set the GRPC bind port for the service. All other services use the format <SERVICE_NAME>_GRPC_ADDR for GRPC, and <SERVICE_NAME>_HTTP_ADDR for HTTP. This change brings it in line with the others, as it's confusing why this one is different.
wkloucek
force-pushed
the
rpocklin-storage-metadata-grpc-env-var-fix
branch
from
75989e3
to
412d3e2
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
wkloucek
added a commit
to owncloud/ocis-charts
that referenced
this pull request
Feb 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently STORAGE_METADATA_GRPC_PROVIDER_ADDR environment variable used as the way to set the GRPC bind port for the service. All other services use the format <SERVICE_NAME>_GRPC_ADDR for GRPC, and <SERVICE_NAME>_HTTP_ADDR for HTTP.
Motivation and Context
This change brings it in line with the others, as it's confusing why this one is different.
How Has This Been Tested?
Simple test is to run the following:
docker run -d --name ocis -e OCIS_RUN_EXTENSIONS="storage-metadata" -e STORAGE_METADATA_GRPC_ADDR="0.0.0.0:9215" owncloud/ocisCheck port this service is bound to (expect it to bind to external address):
docker exec -it ocis /usr/bin/nc -zv 172.17.0.2:9215Expect to see:
172.17.0.2:9215 (172.17.0.2:9215) openTypes of changes
This is possibly a breaking change but a search of the source code finds no specific references to this variable anywhere.
Checklist: