Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add profile_picture to user capabilities #2036

Merged
merged 1 commit into from
May 16, 2021
Merged

Add profile_picture to user capabilities #2036

merged 1 commit into from
May 16, 2021

Conversation

pascalwengerter
Copy link
Contributor

@pascalwengerter pascalwengerter commented May 7, 2021 •
edited
Loading

Description

Needs a PR in reva merged and then the reva version to be updated, will finalize this PR once that's done

Adds the newly introduced capability in the latest reva version to oCIS' capabilities

Related Issue

@update-docs
Copy link

update-docs bot commented May 7, 2021

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@pascalwengerter pascalwengerter changed the title Add profile_picture to user capabilities [WIP] Add profile_picture to user capabilities May 7, 2021
@pascalwengerter pascalwengerter force-pushed the introduce-user-profile-picture-capability branch 2 times, most recently from b67fac3 to 58adff9 Compare May 12, 2021 13:36
@pascalwengerter pascalwengerter changed the title [WIP] Add profile_picture to user capabilities Add profile_picture to user capabilities May 12, 2021
@pascalwengerter pascalwengerter requested a review from refs May 12, 2021 13:37
kulmann
kulmann approved these changes May 12, 2021
View reviewed changes
Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@pascalwengerter pascalwengerter force-pushed the introduce-user-profile-picture-capability branch from 58adff9 to 73bba79 Compare May 12, 2021 13:53
@pascalwengerter pascalwengerter force-pushed the introduce-user-profile-picture-capability branch from 73bba79 to 68f119f Compare May 12, 2021 13:53
@sonarcloud
Copy link

sonarcloud bot commented May 12, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@kulmann kulmann merged commit 54a196a into master May 16, 2021
@delete-merged-branch delete-merged-branch bot deleted the introduce-user-profile-picture-capability branch May 16, 2021 07:19
@kulmann kulmann mentioned this pull request May 16, 2021
Closed
ownclouders pushed a commit that referenced this pull request May 16, 2021
@kulmann
commit 54a196a
96ebba8 
Merge: a45c4e0 68f119f
Author: Benedikt Kulmann <benedikt@kulmann.biz>
Date:   Sun May 16 09:19:17 2021 +0200

    Merge pull request #2036 from owncloud/introduce-user-profile-picture-capability

    Add profile_picture to user capabilities
@renovate renovate bot mentioned this pull request Jun 7, 2021
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kulmann kulmann kulmann approved these changes

@refs refs Awaiting requested review from refs

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Communicate capability of showing user avatar images
2 participants
@pascalwengerter @kulmann