Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added h1 for screenreaders #1991

Merged
merged 1 commit into from
Apr 29, 2021
Merged

Added h1 for screenreaders #1991

merged 1 commit into from
Apr 29, 2021

Conversation

AlexAndBear
Copy link
Contributor

@AlexAndBear AlexAndBear commented Apr 29, 2021 •
edited
Loading

Description

Loginscreen (ocis) - add a (hidden) login headline (h1-tag) would be nice

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@AlexAndBear AlexAndBear force-pushed the a11y-account-page-introduce-form-with-h-tag branch from d4f808e to 8c00e02 Compare April 29, 2021 14:29
@owncloud owncloud deleted a comment from update-docs bot Apr 29, 2021
@AlexAndBear AlexAndBear marked this pull request as ready for review April 29, 2021 14:29
pascalwengerter
pascalwengerter approved these changes Apr 29, 2021
View reviewed changes
Copy link
Contributor

@pascalwengerter pascalwengerter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏽

@sonarcloud
Copy link

sonarcloud bot commented Apr 29, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@AlexAndBear AlexAndBear merged commit dd75e1c into master Apr 29, 2021
@delete-merged-branch delete-merged-branch bot deleted the a11y-account-page-introduce-form-with-h-tag branch April 29, 2021 17:53
ownclouders pushed a commit that referenced this pull request Apr 29, 2021
commit dd75e1c
c6214ff 
Merge: 4239fb5 8c00e02
Author: Jan Ackermann <jackermann@owncloud.com>
Date:   Thu Apr 29 19:53:43 2021 +0200

    Merge pull request #1991 from owncloud/a11y-account-page-introduce-form-with-h-tag

    Added h1 for screenreaders
@renovate renovate bot mentioned this pull request Jun 7, 2021
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pascalwengerter pascalwengerter pascalwengerter approved these changes

@kulmann kulmann Awaiting requested review from kulmann

@fschade fschade Awaiting requested review from fschade

@JammingBen JammingBen Awaiting requested review from JammingBen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AlexAndBear @pascalwengerter