-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate the s3ng storage driver #1886
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
aduffeck
force-pushed
the
s3ng-integration
branch
2 times, most recently
from
April 7, 2021 09:37
2a5f3f9
to
b1ef03d
Compare
butonic
requested changes
Apr 14, 2021
@@ -146,6 +146,7 @@ func StorageUsersWithConfig(cfg *config.Config) []cli.Flag { | |||
flags = append(flags, DriverLocalWithConfig(cfg)...) | |||
flags = append(flags, DriverOwnCloudWithConfig(cfg)...) | |||
flags = append(flags, DriverOCISWithConfig(cfg)...) | |||
flags = append(flags, DriverS3NGWithConfig(cfg)...) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also add this to storagemetadata.go
pls
aduffeck
force-pushed
the
s3ng-integration
branch
from
May 12, 2021 06:56
d780efd
to
3d0741d
Compare
aduffeck
force-pushed
the
s3ng-integration
branch
from
May 12, 2021 07:24
3d0741d
to
9e3766a
Compare
aduffeck
force-pushed
the
s3ng-integration
branch
from
May 12, 2021 08:02
9e3766a
to
6c3280c
Compare
butonic
reviewed
May 12, 2021
butonic
approved these changes
May 12, 2021
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Make the s3ng storage driver available to users.