Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix token cache TTL #1699

Merged
merged 1 commit into from
Feb 22, 2021
Merged

fix token cache TTL #1699

merged 1 commit into from
Feb 22, 2021

Conversation

C0rby
Copy link
Contributor

@C0rby C0rby commented Feb 22, 2021

The TTL was supplied to the middleware as a duration and then in that middleware multiplied by time.Second again. Durations should not be multiplied because they result in unintended values.

           time.Second * 1 = 1s
           time.Second * time.Second = 277777h46m40s

fix token cache TTL
7ad38d7 
The TTL was supplied to the middleware as a duration and then in that middleware multiplied by `time.Second` again. Durations should not be multiplied because they result in unintended values.
```go
	time.Second * 1 = 1s
	time.Second * time.Second = 277777h46m40s
```
@C0rby C0rby requested review from IljaN, butonic and refs February 22, 2021 17:42
@C0rby C0rby self-assigned this Feb 22, 2021
@sonarcloud
Copy link

sonarcloud bot commented Feb 22, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@butonic butonic merged commit 4fffec0 into master Feb 22, 2021
@delete-merged-branch delete-merged-branch bot deleted the fix-token-ttl branch February 22, 2021 19:36
ownclouders pushed a commit that referenced this pull request Feb 22, 2021
@butonic
commit 4fffec0
c5ecd66 
Merge: bbb94c4 7ad38d7
Author: Jörn Friedrich Dreyer <jfd@butonic.de>
Date:   Mon Feb 22 20:36:05 2021 +0100

    Merge pull request #1699 from owncloud/fix-token-ttl

    fix token cache TTL
@micbar micbar mentioned this pull request Mar 9, 2021
Closed
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@butonic butonic butonic approved these changes

@IljaN IljaN Awaiting requested review from IljaN

@refs refs Awaiting requested review from refs

Assignees

@C0rby C0rby

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@C0rby @butonic