Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display share indicator when listing files #929

Closed
C0rby opened this issue Nov 23, 2020 · 5 comments
Closed

Display share indicator when listing files #929

C0rby opened this issue Nov 23, 2020 · 5 comments
Assignees
Labels
Interaction:Needs-Concept Interaction:Needs-help Asking some hints to engineering when the issue can't be reproduced Type:Design Type:Technical-Debt

Comments

@C0rby
Copy link
Contributor

C0rby commented Nov 23, 2020

When a resource (file/folder) has been shared we should show the appropriate share indicator.

@C0rby C0rby self-assigned this Nov 23, 2020
C0rby pushed a commit to owncloud/reva that referenced this issue Nov 23, 2020
C0rby pushed a commit to owncloud/reva that referenced this issue Nov 25, 2020
C0rby pushed a commit to owncloud/reva that referenced this issue Nov 25, 2020
C0rby pushed a commit to owncloud/reva that referenced this issue Nov 25, 2020
C0rby pushed a commit to owncloud/reva that referenced this issue Dec 2, 2020
C0rby pushed a commit to owncloud/reva that referenced this issue Dec 2, 2020
@refs refs changed the title Display share indicator when listing files. Display share indicator when listing files Jan 13, 2021
@refs refs added Category:Feature Interaction:Needs-help Asking some hints to engineering when the issue can't be reproduced Interaction:Needs-Concept Type:Design labels Jan 13, 2021
@settings settings bot removed the p3-medium label Apr 7, 2021
@stale
Copy link

stale bot commented Jun 6, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 10 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Status:Stale label Jun 6, 2021
@stale stale bot closed this as completed Jun 16, 2021
@stale stale bot removed the Status:Stale label Jun 18, 2021
@pascalwengerter
Copy link
Contributor

@C0rby could you update this issue / close it if it was finished off in the current sprint (sync bot suggests so)

@C0rby
Copy link
Contributor Author

C0rby commented Jul 2, 2021

So there are multiple things to this.

  • Propfinds include shareinformation for direct shares (users,groups)
    • The indicators for direct shares are displayed for the items in the root and in subfolders
  • Propfinds to not include share information for public links
    • Share indicators for public links are not shown in the root but in subfolders
      This is because the webui does an extra request in subfolders to receive a list with shares

Including public link share information into the propfind response is a bit difficult since it would require to do a request against the share manager for every file in the propfind response. This would slow down the process significantly which is why we haven't implemented this yet.

If this has a high priority/is a strict requirement than we need to take another look and possibly refactor the sharing architecture.

@stale
Copy link

stale bot commented Aug 31, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 10 days if no further activity occurs. Thank you for your contributions.

@wkloucek
Copy link
Contributor

This looks all solved to me. See also #1038 (comment).

Please reopen and describe if there is still a TODO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Interaction:Needs-Concept Interaction:Needs-help Asking some hints to engineering when the issue can't be reproduced Type:Design Type:Technical-Debt
Projects
None yet
Development

No branches or pull requests

4 participants