Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not deploy auth-bearer service by default #4692

Closed
rhafer opened this issue Sep 27, 2022 · 0 comments · Fixed by #4702
Closed

Do not deploy auth-bearer service by default #4692

rhafer opened this issue Sep 27, 2022 · 0 comments · Fixed by #4702
Assignees
@rhafer
Labels
Type:Bug
Milestone
2.0.0 General Ava...

Comments

@rhafer
Copy link
Contributor

rhafer commented Sep 27, 2022

Describe the bug

Currently the auth-bearer reva-service is not used by ocis (see #4616 for details). All verification for oidc tokens is done by a separate middleware in ocis. Be should not start it by default and remove it from the example deployments.

In the longer might be a good idea to rework the ocis middleware in the proxy to use the auth-bearer service. This would get us rid of quite a bit of redundant functionality. (But would also require some work on the auth-bearer service)
@rhafer rhafer mentioned this issue Sep 27, 2022
Closed
@butonic butonic added this to the 2.0.0 General Availability milestone Sep 28, 2022
@rhafer rhafer self-assigned this Sep 28, 2022
@rhafer rhafer mentioned this issue Sep 28, 2022
Open
rhafer added a commit to rhafer/ocis that referenced this issue Sep 28, 2022
@rhafer
Do not start auth-bearer service by default
306dcef 
The auth-bearer service is currently not needed by ocis. Reva tookens for oidc
authenticated clients are currently minted via the auth-machine service.
This commit does not completely remove the service as we shoud consider
to rework the proxy's oidc middleware to use the auth-bearer service in
the future (see owncloud#4701)

Fixes: owncloud#4692
@rhafer rhafer mentioned this issue Sep 28, 2022
Merged
rhafer added a commit to rhafer/ocis that referenced this issue Sep 28, 2022
@rhafer
Do not start auth-bearer service by default
5d121b4 
The auth-bearer service is currently not needed by ocis. Reva tookens
for oidc authenticated clients are currently minted via the auth-machine
service.  This commit does not completely remove the service as we shoud
consider to rework the proxy's oidc middleware to use the auth-bearer
service in the future (see owncloud#4701)

Fixes: owncloud#4692
@micbar micbar mentioned this issue Nov 25, 2022
Closed
73 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rhafer rhafer

Labels
Type:Bug
Projects
Infinite Scale Team Board
Archived in project
Milestone
2.0.0 General Availability
Development

Successfully merging a pull request may close this issue.

[full-ci] Do not start auth-bearer service by default rhafer/ocis
2 participants
@rhafer @butonic