Skip to content

Commit

Permalink
add readme
Browse files Browse the repository at this point in the history
  • Loading branch information
refs committed Feb 23, 2021
1 parent 78eabd2 commit 0a18cc2
Showing 1 changed file with 9 additions and 0 deletions.
9 changes: 9 additions & 0 deletions changelog/unreleased/fix-accounts-service-initialization.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
Bugfix: Fix accounts initialization

Originally the accounts service relies on both the `settings` and `storage-metadata` to be up and running at the moment it starts. This is an antipattern as it will cause the entire service to panic if the dependants are not present.

We inverted this dependency and moved the default initialization data (i.e: creating roles, permissions, settings bundles) and instead of notifying the settings service that the account has to provide with such options, the settings is instead initialized with the options the accounts rely on. Essentially saving bandwith as there is no longer a gRPC call to the settings service.

For the `storage-metadata` a retry mechanism was added that retries by default 20 times to fetch the `com.owncloud.storage.metadata` from the service registry every `500` miliseconds. If this retry expires the accounts panics, as its dependency on the `storage-metadata` service cannot be resolved.

https://github.com/owncloud/ocis/pull/1696a

0 comments on commit 0a18cc2

Please sign in to comment.