Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature/localsearch] Local account-wide search using custom queries #933

Merged
merged 42 commits into from
Apr 20, 2021

Commits on Mar 17, 2021

  1. Configuration menu
    Copy the full SHA
    ea6c868 View commit details
    Browse the repository at this point in the history
  2. - clean up QueryFileListTableViewController.swift

    - replace all/folder text in scope selection with icons on iOS 13+
    felix-schwarz committed Mar 17, 2021
    Configuration menu
    Copy the full SHA
    e059a8d View commit details
    Browse the repository at this point in the history
  3. - SortMethod

    	- turn localizedName from a function into a property
    	- add sortPropertyName to simplify construction of custom OCQuerys
    - ClientQueryViewController
    	- add sort property, sort order and result limits to OCQueryCondition
    	- refresh search query when changing sort order and peak results
    felix-schwarz committed Mar 17, 2021
    Configuration menu
    Copy the full SHA
    4572040 View commit details
    Browse the repository at this point in the history

Commits on Mar 23, 2021

  1. - UIView+Extension: add simply methods to start/stop a pulsing effect…

    … on a view
    
    - ServerListTableViewController
    	- add user activity to allow state restoring to server list (previously only *always* to the last opened bookmark)
    	- remove auto login code for pre-iOS 13 (in iOS 13 that's handled by scene/state restoration)
    	- add inline status reporting for database migrations
    - SceneDelegate: add support to state restore to server list
    - ClientQueryViewController
    	- switch to search tokenizer to construct OCQueryCondition
    	- make sure sort / search options are no longer hidden when showing large "No results" message
    - ClientRootViewController
    	- add support for migration progress reporting / OCCoreBusyStatusHandler passing
    	- fix OCFileProviderServiceStandby leak if OCCoreManager returns a request with an error
    - FileProvider extension
    	- return an error when trying to access an account whose database needs migration
    	- handle case where no OCCore is available
    - MessageView: add option to show messages with insets at the edges
    - NSDate+ComputedTimes:
    	- simplified computation of beginning of days, weeks, months and years, with support for offsets
    	- add unit test
    - OCQueryCondition+SearchSegmenter:
    	- segmentation of search queries into terms and "keywords"
    	- supports placing terms in "" as well as unclosed "
    	- keyword support to filter for:
    		- files (:file), folders (:folder),
    		- images (:image), video (:video)
    		- time frames (:today, :week, :month, :year)
    		- dynamic time frames (:7d, :2w, :1m, :1y, days:7, weeks:2, month:1, year:1, …)
    		- file types/suffixes (type:jpg)
    	- add unit test
    felix-schwarz committed Mar 23, 2021
    Configuration menu
    Copy the full SHA
    e53e51a View commit details
    Browse the repository at this point in the history
  2. - add "Show more results" row at the end of the search result list if…

    … there could be more results
    felix-schwarz committed Mar 23, 2021
    Configuration menu
    Copy the full SHA
    b18df1d View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    75cc69e View commit details
    Browse the repository at this point in the history

Commits on Mar 24, 2021

  1. - QueryFileListTableViewController: search remains active after choos…

    …ing an item and then navigating back to search
    
    - ClientQueryViewController: adapt to QueryFileListTableViewController changes
    felix-schwarz committed Mar 24, 2021
    Configuration menu
    Copy the full SHA
    4fbcf1b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    9a39982 View commit details
    Browse the repository at this point in the history
  3. - BreadCrumbTableViewController

    	- add navigationHandler property to allow custom navigation actions to get triggered by the breadcrumb view
    - ClientItemCell
    	- add reveal button support
    - ClientQueryViewController / QueryFileListTableViewController
    	- allow providing an item to reveal and highlight
    	- allow specifying if bread crumbs should push new view controllers
    	- show reveal arrows for custom queries
    felix-schwarz committed Mar 24, 2021
    Configuration menu
    Copy the full SHA
    469db00 View commit details
    Browse the repository at this point in the history
  4. - fix issue of stopped custom query after revealing an item and retur…

    …ning
    
    - use search term segmentation also for folder search (via OCQueryCondition+Item)
    felix-schwarz committed Mar 24, 2021
    Configuration menu
    Copy the full SHA
    53e8f19 View commit details
    Browse the repository at this point in the history

Commits on Mar 25, 2021

  1. - OCBookmark+AppExtensions: check if displayName and userName have at…

    … least one character before using them
    felix-schwarz committed Mar 25, 2021
    Configuration menu
    Copy the full SHA
    0f86503 View commit details
    Browse the repository at this point in the history
  2. - update SDK

    - add concept and property of activeQuery to QueryFileListTableViewController
    - adopt activeQuery in ClientQueryViewController to prevent QueryFileListTableViewController from controlling the customSearchQuery / run into conflicts
    - resolve issue where a "Stopped" status was displayed sometimes when returning from a revealed search result
    felix-schwarz committed Mar 25, 2021
    Configuration menu
    Copy the full SHA
    a78f0f9 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    6781091 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    458ffa6 View commit details
    Browse the repository at this point in the history

Commits on Mar 29, 2021

  1. - NSDate+ComputedTimes

    	- add date parsing for strings following [year]-[[month][-[day]]] syntax
    	- clarify all other method names
    - NSString+ByteCountParser: parse strings into byte counts, support TB, TiB, GB, GiB, MB, MiB, B and bytes-without-B
    - OCQueryCondition+SearchSegmenter
    	- add support for localized keywords in local search
    	- clean up keywords, removing kind-of-duplicates
    	- add new keywords:
    		- after: return items last modified after the given date
    		- before: return items last modified before the given date
    		- on: return items last modified on the given date
    		- smaller: return items less than this size
    		- greater: return items greater than this size
    felix-schwarz committed Mar 29, 2021
    Configuration menu
    Copy the full SHA
    18f1ef8 View commit details
    Browse the repository at this point in the history

Commits on Mar 30, 2021

  1. Configuration menu
    Copy the full SHA
    81f3e70 View commit details
    Browse the repository at this point in the history
  2. - update SDK to add item sync info scrubbing capabilities

    - address Xcode / linter warnings
    felix-schwarz committed Mar 30, 2021
    Configuration menu
    Copy the full SHA
    d9fdee2 View commit details
    Browse the repository at this point in the history

Commits on Apr 8, 2021

  1. OCQueryCondition+SearchSegmenter:

    - add full localization + normalization of keywords
    - add English and German localization
    felix-schwarz committed Apr 8, 2021
    Configuration menu
    Copy the full SHA
    e397d7c View commit details
    Browse the repository at this point in the history
  2. - update SDK

    - remove leftover code
    felix-schwarz committed Apr 8, 2021
    Configuration menu
    Copy the full SHA
    4e4416d View commit details
    Browse the repository at this point in the history
  3. - QueryFileListTableViewController: remove unneeded/conflicting searc…

    …hScope initialization
    
    - added missing localizations
    felix-schwarz committed Apr 8, 2021
    Configuration menu
    Copy the full SHA
    0f5b886 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    5883b23 View commit details
    Browse the repository at this point in the history

Commits on Apr 9, 2021

  1. Code review suggestion for PR #933:

    - hide multiselect button, when search is active
    - use labels instead of images for search scope segmented control
    - changed more button width for better UI alignment
    - changed multiselect button width for better touch experience
    hosy committed Apr 9, 2021
    Configuration menu
    Copy the full SHA
    356d42b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    76547c9 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    5809985 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    6d62dde View commit details
    Browse the repository at this point in the history

Commits on Apr 12, 2021

  1. - fixed showing and executing keyboard shortcuts when search is activ…

    …e in file list (was not shown, because action was not available in performing class)
    
    - added "Toggle Search Scope" keyboard shortcut
    - scroll file list to top, when search will be activated
    hosy committed Apr 12, 2021
    Configuration menu
    Copy the full SHA
    ce81cac View commit details
    Browse the repository at this point in the history
  2. - comment out parts of KeyCommands that seem to interfere with entry …

    …of search text, jumping to entries with the letters instead
    
    - scroll to top when results change
    - add support for negating search terms by prefixing them with "-", i.e. "-word" to exclude results with "word" in it
    felix-schwarz committed Apr 12, 2021
    Configuration menu
    Copy the full SHA
    77979e1 View commit details
    Browse the repository at this point in the history

Commits on Apr 13, 2021

  1. - disable keyboard shortcuts for letters, if search is active

    - make search field first responder, when toggle search scope
    hosy committed Apr 13, 2021
    Configuration menu
    Copy the full SHA
    527ab4d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    b89987a View commit details
    Browse the repository at this point in the history
  3. - logging improvements: use OCFileOpLog to log file operation in OCCo…

    …re+BundleImport.m
    
    - update SDK
    felix-schwarz committed Apr 13, 2021
    Configuration menu
    Copy the full SHA
    e09822e View commit details
    Browse the repository at this point in the history

Commits on Apr 15, 2021

  1. Configuration menu
    Copy the full SHA
    372d798 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    6ae8242 View commit details
    Browse the repository at this point in the history
  3. - OCQueryCondition+SearchSegmenter: accept more possible quotation ma…

    …rks when segmenting searches
    felix-schwarz committed Apr 15, 2021
    Configuration menu
    Copy the full SHA
    38ad27d View commit details
    Browse the repository at this point in the history
  4. OCQueryCondition+SearchSegmenter: allow inactivation of keywords thro…

    …ugh quotation, make it possible to still negate such searches
    felix-schwarz committed Apr 15, 2021
    Configuration menu
    Copy the full SHA
    2e67485 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    0ea4bb9 View commit details
    Browse the repository at this point in the history

Commits on Apr 16, 2021

  1. fixed QA finding (8): keyboard commands for search and sort order whe…

    …re missing in directory picker
    hosy committed Apr 16, 2021
    Configuration menu
    Copy the full SHA
    002ee67 View commit details
    Browse the repository at this point in the history
  2. - SortBar: new allowMultiSelect property to control whether multi sel…

    …ect should be available, defaulting to true
    
    - QueryFileListTableViewController, ClientQueryViewController: allow efficient subclassing of relevant parts of the reveal feature
    - ClientDirectoryPickerViewController: provide implementations of relevant reveal subclassing points, disable multi-select (fixing finding (7) and (9) in #933)
    felix-schwarz committed Apr 16, 2021
    Configuration menu
    Copy the full SHA
    4fddedf View commit details
    Browse the repository at this point in the history
  3. - update SDK to add database support for ownerUserName

    - search segmenter: add support for owner keyword, incl. localization
    felix-schwarz committed Apr 16, 2021
    Configuration menu
    Copy the full SHA
    399ed6d View commit details
    Browse the repository at this point in the history

Commits on Apr 19, 2021

  1. fixed duplicated keyboard commands:

    changed keyboard command for toggle search order and share item
    hosy committed Apr 19, 2021
    Configuration menu
    Copy the full SHA
    89200c3 View commit details
    Browse the repository at this point in the history

Commits on Apr 20, 2021

  1. Configuration menu
    Copy the full SHA
    3b397f0 View commit details
    Browse the repository at this point in the history
  2. added changelog entry

    hosy committed Apr 20, 2021
    Configuration menu
    Copy the full SHA
    69dc227 View commit details
    Browse the repository at this point in the history
  3. Calens changelog updated

    hosy authored and actions-user committed Apr 20, 2021
    Configuration menu
    Copy the full SHA
    9c8de15 View commit details
    Browse the repository at this point in the history