[tests-only][full-ci]Refactor closed issue related scenarios

[amrita-shrestha]

Description

This PR refactor scenario in closed issue to work

Point to note

• robots.txt file is generated at the time of ocis build in ocis but ore-exist in the core. Currently, we cache ocis binary only. That's why this scenario
  Scenario: robots.txt file should be accessible
  passes in the core but fails in ocis (This step checks the content of the robot.txt file in the services/web/assets/robot.txt path which is not cached currently).In CI, we store ocis binary in the cache. This scenario requests for robots.txt content through an API request. It was decided that we can check the content of robots.txt by passing value from step. If in the future robots.txt value changes then this scenario starts to fail.

• As discussed in can't access public link resources with spaces webdav API ocis#3085 (comment), public-link will not be implemented using space WebDAV so removing it

Related Issue

• Check closed issue Searching sharee with displayname still exist in expected-to-failure ocis#4684
• Closed issue No robots.txt available still exist in expected-to-failure ocis#4685
• Closed issue can't access public link resources with spaces webdav API still exist in expected-to-failure ocis#4687

Motivation and Context

How Has This Been Tested?

• locally

Screenshots (if appropriate):

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Database schema changes (next release will require increase of minor version instead of patch)
• Breaking change (fix or feature that would cause existing functionality to change)
• Technical debt
• Tests only (no source changes)

Checklist:

• Code changes
• Unit tests added
• Acceptance tests added
• Documentation ticket raised:
• Changelog item, see TEMPLATE

[kiranparajuli589]

rest lgtm 👍

[kiranparajuli589]

Download API may end with 200(Complete) or 206(Partial). for these two cases, the downloaded content is different. the scenarios tries to cope with both cases,

• if status code is 206, the content check step for status 200 is skipped and vice versa
• content check step requires the status because it differs with the HTTP status received in the download request.

Please refactor you code accordingly. The step words a is bit confusing (at least for me). Adding some comments may help others coming here.

[saw-jan]

LGTM

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

[grgprarup]

LGTM 👍