Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests-only] Escape $ in href response #40029

Merged
merged 2 commits into from
Apr 28, 2022
Merged

[tests-only] Escape $ in href response #40029

merged 2 commits into from
Apr 28, 2022

Conversation

kobergj
Copy link
Contributor

@kobergj kobergj commented Apr 28, 2022

Signed-off-by: jkoberg jkoberg@owncloud.com

Description

Related Issue

  • Fixes <issue_link>

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@micbar micbar merged commit 8f4783a into master Apr 28, 2022
@delete-merged-branch delete-merged-branch bot deleted the ExcapeDollarForHref branch April 28, 2022 16:26
@micbar micbar restored the ExcapeDollarForHref branch April 28, 2022 16:26
@butonic butonic deleted the ExcapeDollarForHref branch April 28, 2022 18:27
@butonic butonic restored the ExcapeDollarForHref branch April 28, 2022 18:28
@phil-davis phil-davis deleted the ExcapeDollarForHref branch April 29, 2022 03:40
@phil-davis phil-davis restored the ExcapeDollarForHref branch April 29, 2022 03:40
@individual-it
Copy link
Member

Why do we need this? Would be good some explanation in the PR

@phil-davis
Copy link
Contributor

Note: this branch is currently referenced by cs3org/reva edge branch. So do not delete the branch.

@micbar
Copy link
Contributor

micbar commented Apr 29, 2022

in cs3org/reva#2790 we changed the resource IDs in reva to become <storageproviderid>$<rootnodeid>!<nodeid>.

That will enable us to use a static registry. So all resource IDs will have a storageproviderid in the space id.

@kobergj
Copy link
Contributor Author

kobergj commented Apr 29, 2022

@individual-it We changed the format of the storageid to be of form "providerid$spaceid", thus we need to escape it now otherwise strings don't match in multiple tests.

@phil-davis this branch can be savely deleted. I have another branch which is based on the commit used in edge. This one here is based on master to avoid conflicts and side effects.

@kobergj kobergj deleted the ExcapeDollarForHref branch April 29, 2022 07:16
@kobergj kobergj mentioned this pull request Apr 29, 2022
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants