Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests-only] Skip intermittent test on oc storage #38900

Closed
wants to merge 1 commit into from

Conversation

kiranparajuli589
Copy link
Contributor

@kiranparajuli589 kiranparajuli589 commented Jun 28, 2021

Description

trashbin restore scenario is skipped on ocis oc storage
Scenario Outline: restoring a file to an already existing path overrides the file

Related Issue

Motivation and Context

owncloud/ocis#2211 (comment)

How Has This Been Tested?

  • 🤖

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

Copy link
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will merge this later this evening, if there is no obvious fix available today.

Note: I need to think about what we can do about intermittent test scenarios. It is annoying to have to edit tags in core, and it (maybe) would be nice to have them running in OCIS and reva CI (so we do not have to edit core again to unskip them)

@sonarcloud
Copy link

sonarcloud bot commented Jun 28, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@phil-davis phil-davis marked this pull request as draft June 28, 2021 11:27
@phil-davis
Copy link
Contributor

Waiting to see what happens with cs3org/reva#1833

@phil-davis
Copy link
Contributor

cs3org/reva#1833 fix has been merged. It might get into OCIS today - let's see.

@phil-davis
Copy link
Contributor

The problem of issue owncloud/ocis#2221 was fixed in the owncloud storage driver in cs3org/reva and has been pulled into OCIS. This test now works fine on all OCIS storages. So we do not need to skip it.

@phil-davis phil-davis closed this Jul 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants