solve bug of hiding of fab on opening snackbar #2105
Conversation
|
Hi @harshitbansal05 , thanks for this contribution, I've just reviewed the code and looks good to me. Please rebase with master and @jesmrec will perform some tests. |
harshitbansal05
force-pushed
the
fab-snackbar-bug
branch
from
c6e527f
to
59c1fd6
Compare
|
@jesmrec could you please review this? |
|
@harshitbansal05 i will, i ping you when i start QA process and notify you if i detect something to be reviewed. |
|
@jesmrec meanwhile should I make pull requests for other issues(which i wished to work on)? |
|
The issues labelled with "Contributions are welcome" are good choices to send PRs as first approaches to the app. |
|
@harshitbansal05 please rebase the branch in order to fix the existing conflict and start the tiny QA stage to approve the current PR. Thanks. |
|
@jesmrec can I fix the merge conflict upon rebasing? |
|
@harshitbansal05 , yes. Please have a look at this @davigonz's explanation about rebasing: |
|
@harshitbansal05 if you have problems in rebasing process, please let us know and we can help you. Thanks. |
harshitbansal05
force-pushed
the
fab-snackbar-bug
branch
from
59c1fd6
to
b347351
Compare
|
Tested in both orientations for Nexus 6P v7.1.2 and Galaxy Tab S2 v6.0.1. Approved. @harshitbansal05, please rebase and we will take care of merging. |
|
@jesmrec @harshitbansal05 I will merge this code via #2203, thanks for the contribution |
This pr solves issue #2104. It addresses all the cases where opening of the snackbar partially overlaps with the floating action menu. It uses the default property of coordinator layout to solve this.