Pattern Lock Added #2083
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,64 @@ | ||
| <?xml version="1.0" encoding="utf-8"?> | ||
|
There was a problem hiding this comment. Do you need a specific landscape view? Does not the CANCEL button fit below the pattern? If so, portrait view would be enough
There was a problem hiding this comment. @davigonz Yes in some devices the cancel button does not fit in landscape orientation. So should I remove this view? There was a problem hiding this comment. Ok, if it does not fit in some devices, keep this landscape view 👍 |
||
| <RelativeLayout xmlns:android="http://schemas.android.com/apk/res/android" | ||
| xmlns:app="http://schemas.android.com/apk/res-auto" | ||
| android:layout_width="fill_parent" | ||
| android:layout_height="fill_parent" | ||
| android:filterTouchesWhenObscured="true" | ||
| android:gravity="center_horizontal" | ||
| android:padding="@dimen/standard_padding"> | ||
|
|
||
| <LinearLayout | ||
| android:layout_width="wrap_content" | ||
| android:layout_height="wrap_content" | ||
| android:layout_centerVertical="true" | ||
| android:gravity="center_horizontal" | ||
| android:orientation="vertical"> | ||
|
|
||
| <TextView | ||
| android:id="@+id/header_pattern" | ||
| android:layout_width="wrap_content" | ||
| android:layout_height="wrap_content" | ||
| android:text="@string/pattern_enter_pattern" | ||
| android:textColor="@android:color/black" | ||
| android:textSize="16sp" /> | ||
|
|
||
| <TextView | ||
| android:id="@+id/explanation_pattern" | ||
| android:layout_width="wrap_content" | ||
| android:layout_height="wrap_content" | ||
| android:gravity="center_horizontal" | ||
| android:text="@string/pattern_configure_your_pattern_explanation" | ||
| android:textAppearance="@android:style/TextAppearance.Small" | ||
| android:textSize="14sp" /> | ||
|
|
||
| <RelativeLayout | ||
| android:layout_width="wrap_content" | ||
| android:layout_height="wrap_content"> | ||
|
|
||
| <com.andrognito.patternlockview.PatternLockView | ||
| android:id="@+id/pattern_lock_view" | ||
| android:layout_width="250dp" | ||
| android:layout_height="250dp" | ||
| android:focusable="true" | ||
| app:correctStateColor="@color/primary" | ||
| app:dotCount="3" | ||
| app:normalStateColor="@color/primary" | ||
| app:wrongStateColor="@color/primary"> | ||
|
|
||
| <requestFocus /> | ||
| </com.andrognito.patternlockview.PatternLockView> | ||
|
|
||
| <android.support.v7.widget.AppCompatButton | ||
| android:id="@+id/cancel_pattern" | ||
| android:layout_width="wrap_content" | ||
| android:layout_height="wrap_content" | ||
| android:layout_centerVertical="true" | ||
| android:layout_toRightOf="@id/pattern_lock_view" | ||
| android:text="@string/common_cancel" | ||
| android:theme="@style/Button.Primary" /> | ||
|
|
||
| </RelativeLayout> | ||
|
|
||
| </LinearLayout> | ||
|
|
||
| </RelativeLayout> | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,56 @@ | ||
| <?xml version="1.0" encoding="utf-8"?> | ||
| <RelativeLayout xmlns:android="http://schemas.android.com/apk/res/android" | ||
| xmlns:app="http://schemas.android.com/apk/res-auto" | ||
| android:layout_width="fill_parent" | ||
| android:layout_height="fill_parent" | ||
| android:filterTouchesWhenObscured="true" | ||
| android:gravity="center_horizontal" | ||
| android:padding="@dimen/standard_padding"> | ||
|
|
||
| <LinearLayout | ||
| android:layout_width="wrap_content" | ||
| android:layout_height="wrap_content" | ||
| android:layout_centerVertical="true" | ||
| android:gravity="center_horizontal" | ||
| android:orientation="vertical"> | ||
|
|
||
| <TextView | ||
| android:id="@+id/header_pattern" | ||
| android:layout_width="wrap_content" | ||
| android:layout_height="wrap_content" | ||
| android:text="@string/pattern_enter_pattern" | ||
| android:textColor="@android:color/black" | ||
| android:textSize="16sp" /> | ||
|
|
||
| <TextView | ||
| android:id="@+id/explanation_pattern" | ||
| android:layout_width="wrap_content" | ||
| android:layout_height="wrap_content" | ||
| android:gravity="center_horizontal" | ||
| android:text="@string/pattern_configure_your_pattern_explanation" | ||
| android:textAppearance="@android:style/TextAppearance.Small" | ||
| android:textSize="14sp" /> | ||
|
|
||
| <com.andrognito.patternlockview.PatternLockView | ||
| android:id="@+id/pattern_lock_view" | ||
| android:layout_width="280dp" | ||
| android:layout_height="280dp" | ||
| android:focusable="true" | ||
| app:correctStateColor="@color/primary" | ||
| app:dotCount="3" | ||
| app:normalStateColor="@color/primary" | ||
| app:wrongStateColor="@color/primary"> | ||
|
|
||
| <requestFocus /> | ||
| </com.andrognito.patternlockview.PatternLockView> | ||
|
|
||
| <android.support.v7.widget.AppCompatButton | ||
| android:id="@+id/cancel_pattern" | ||
| android:layout_width="wrap_content" | ||
| android:layout_height="wrap_content" | ||
| android:text="@string/common_cancel" | ||
| android:theme="@style/Button.Primary" /> | ||
|
|
||
| </LinearLayout> | ||
|
|
||
| </RelativeLayout> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When we use a third-party library we usually include the information in our THIRD_PARTY.txt file. Could you do the same with this library? You can have a look at the format we followed with other libraries in that file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As in this picture for the floating action button dependency it is written that it is placed in libs/com-getbase-floatingactionbutton-1-10-0-exploded-aar. Similarly what should I write for the placed at point (for the pattern lock view dependency).What I mean is what does placed at signify.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Forget this change for the moment, it seems that our THIRD_PARTY.txt is not properly updated, I will ping you when is ready.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@davigonz Then I will commit the other changes. Thanks.