Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔨 Replace polyfill.io in the docs and the site #3279

Merged
merged 1 commit into from
Mar 4, 2024

Conversation

SukkaW
Copy link
Contributor

@SukkaW SukkaW commented Mar 1, 2024

The PR replaces the polyfill.io inside the docs and the site to cdnjs.cloudflare.com/polyfill.


polyfill.io was acquired by a China-based CDN company "Funnull", see the announcement from the polyfill.io domain owner's Twitter and https://github.com/polyfillpolyfill/polyfill-service/issues/2834. Despite Funnull's claims of operating in the United States, the predominance of Simplified Chinese on its website suggests otherwise, and it turns out that "Funnull" is notorious for providing service for the betting and pornography industries.

The original creator of the polyfill.io has voiced his concern on Twitter. And since the acquisition, numerous issues have emerged (polyfillpolyfill/polyfill-service#2835, polyfillpolyfill/polyfill-service#2838, alist-org/alist#6100), rendering the polyfill.io service extremely unstable. Since then, Fastly (Announcement) and Cloudflare (Announcement) has hosted their own instances of polyfill.io service.

@shuuji3
Copy link

shuuji3 commented Mar 3, 2024

@marcelgerber
Copy link
Member

Hi, and thank you for notifying us of this issue.
I'll quickly check how using Cloudflare for this compares performance-wise, but otherwise this is good to go.

@shuuji3
Copy link

shuuji3 commented Mar 4, 2024

Fastly is also providing alternative polyfill CDN (https://community.fastly.com/t/new-options-for-polyfill-io-users/2540). In case of any performance issues, you may evaluate it with Cloudflare as well.

@marcelgerber
Copy link
Member

This works great, thank you again!

@marcelgerber marcelgerber merged commit b36c9b7 into owid:master Mar 4, 2024
9 of 12 checks passed
@larsyencken
Copy link
Contributor

@SukkaW Given the recent supply chain attack using polyfill, we're especially grateful for this contribution of yours some months back. 🙇

https://sansec.io/research/polyfill-supply-chain-attack

@shuuji3
Copy link

shuuji3 commented Jun 27, 2024

Yes, @SukkaW did a great job for various GitHub repositories! 👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants