Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #7263 #11585

Merged
merged 4 commits into from
Jun 5, 2024
Merged

Fixes #7263 #11585

merged 4 commits into from
Jun 5, 2024

Conversation

Jarred-Sumner
Copy link
Collaborator

What does this PR do?

This makes Bun print Infinity as 1 / 0 when either (1) we are not renaming symbols, like at runtime or (2) when bundling with --minify-syntax.

Fixes #7263

Loosely based on evanw/esbuild#1385

Since this is an observable output change, this bumps the runtime transpiler cache version.

How did you verify your code works?

There are some tests

Loosely based on evanw/esbuild#1385
Copy link
Collaborator

@dylan-conway dylan-conway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, code and tests look good

@dylan-conway
Copy link
Collaborator

Looks like expected test failures from output change

Copy link
Contributor

github-actions bot commented Jun 4, 2024

@Jarred-Sumner, your commit has failing tests :(

💪 1 failing tests Darwin AARCH64

  • test/bundler/bundler_string.test.ts 2 failing

💻 1 failing tests Darwin x64 baseline

  • test/bundler/bundler_string.test.ts 2 failing

💻 1 failing tests Darwin x64

  • test/bundler/bundler_string.test.ts 2 failing

🐧💪 1 failing tests Linux AARCH64

  • test/bundler/bundler_string.test.ts 2 failing

🐧🖥 1 failing tests Linux x64 baseline

  • test/bundler/bundler_string.test.ts 2 failing

🐧🖥 1 failing tests Linux x64

  • test/bundler/bundler_string.test.ts 2 failing

🪟💻 7 failing tests Windows x64 baseline

  • test/bundler/bundler_string.test.ts 2 failing
  • test/cli/install/bun-create.test.ts 1 failing
  • test/cli/install/bunx.test.ts 1 failing
  • test/cli/install/registry/bun-install-registry.test.ts 1 failing
  • test/integration/next-pages/test/dev-server.test.ts 1 failing
  • test/integration/next-pages/test/next-build.test.ts 1 failing
  • test/js/node/watch/fs.watchFile.test.ts 3 failing

🪟💻 6 failing tests Windows x64

  • test/bundler/bundler_string.test.ts 2 failing
  • test/cli/install/bunx.test.ts 1 failing
  • test/integration/next-pages/test/dev-server.test.ts 1 failing
  • test/integration/next-pages/test/next-build.test.ts 1 failing
  • test/js/bun/http/serve-body-leak.test.ts 1 failing
  • test/js/node/watch/fs.watchFile.test.ts 3 failing

View logs

@Jarred-Sumner Jarred-Sumner merged commit c7a08f1 into main Jun 5, 2024
@Jarred-Sumner Jarred-Sumner deleted the jarred/minify-infinity branch June 5, 2024 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ReferenceError: Cannot access uninitialized variable.
2 participants