Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/progot #567

Merged
merged 18 commits into from
Aug 7, 2024
Merged

Feature/progot #567

merged 18 commits into from
Aug 7, 2024

Conversation

michalk8
Copy link
Collaborator

@michalk8 michalk8 commented Jul 30, 2024

TODOs:

  • polish the API
  • docstrings
  • polish the tutorial (almost done)
  • tests

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link

codecov bot commented Jul 30, 2024

Codecov Report

Attention: Patch coverage is 29.07801% with 100 lines in your changes missing coverage. Please review.

Project coverage is 88.35%. Comparing base (7dcc09c) to head (1e5ddf9).
Report is 1 commits behind head on main.

Files Patch % Lines
src/ott/tools/progot.py 29.07% 100 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #567      +/-   ##
==========================================
- Coverage   89.46%   88.35%   -1.11%     
==========================================
  Files          71       72       +1     
  Lines        7554     7695     +141     
  Branches     1077     1099      +22     
==========================================
+ Hits         6758     6799      +41     
- Misses        645      745     +100     
  Partials      151      151              
Files Coverage Δ
src/ott/tools/progot.py 29.07% <29.07%> (ø)

... and 1 file with indirect coverage changes

@michalk8 michalk8 added the enhancement New feature or request label Aug 6, 2024
Copy link
Contributor

@marcocuturi marcocuturi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this all looks good to me

@michalk8 michalk8 marked this pull request as ready for review August 7, 2024 08:08
@michalk8 michalk8 merged commit 18bf5be into main Aug 7, 2024
9 of 11 checks passed
@michalk8 michalk8 deleted the feature/progot branch August 7, 2024 08:13
Copy link
Collaborator

@pkassraie pkassraie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants